Differential D7272

[DropJob] Enable drag and drop in a read-only folder
ClosedPublic
Actions

Authored by chinmoyr on Aug 12 2017, 11:20 AM.

Tags

Subscribers

mreeves, ngraham

Details

Reviewers

Group Reviewers

Maniphest Tasks

T6561: Polkit support in KIO

Commits

R241:774b303c9680: [DropJob] Enable drag and drop in a read-only folder

Summary

This patch adds PrivilegeExecution and other relevant code to KIO::DropJob. With this DnD can be done in a read-only folder.

Diff Detail

Repository

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

chinmoyr created this revision.Aug 12 2017, 11:20 AM

chinmoyr added a task: T6561: Polkit support in KIO.Aug 12 2017, 11:21 AM

Looks good otherwise.

(Maybe extend the unittest for dropjob to test the polkit case too?)

src/widgets/dropjob.cpp
107 ↗	(On Diff #18049)	that line is clearly useless, given the line just before.
151 ↗	(On Diff #18049)	can be const again, given the above comment

This revision now requires changes to proceed.Aug 13 2017, 10:03 PM

How are we doing here?

mreeves added a subscriber: mreeves.Dec 14 2017, 4:32 AM

1.Replaced PrivilegeExecution flag
2.Made variable m_flags const again

Restricted Application added a project: Frameworks. · View Herald TranscriptJan 2 2018, 3:54 PM

ping

dfaure accepted this revision.Jan 10 2018, 11:24 PM

This revision is now accepted and ready to land.Jan 10 2018, 11:24 PM

Closed by commit R241:774b303c9680: [DropJob] Enable drag and drop in a read-only folder (authored by chinmoyr). · Explain WhyJan 12 2018, 12:31 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			src/widgets/dropjob.cpp (24 lines)

Diff 24601

src/widgets/dropjob.cpp

Loading...