[DropJob] Enable drag and drop in a read-only folder

Authored by chinmoyr on Aug 12 2017, 11:20 AM.



This patch adds PrivilegeExecution and other relevant code to KIO::DropJob. With this DnD can be done in a read-only folder.

Diff Detail

R241 KIO
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.
chinmoyr created this revision.Aug 12 2017, 11:20 AM
dfaure requested changes to this revision.Aug 13 2017, 10:03 PM

Looks good otherwise.

(Maybe extend the unittest for dropjob to test the polkit case too?)


that line is clearly useless, given the line just before.


can be const again, given the above comment

This revision now requires changes to proceed.Aug 13 2017, 10:03 PM

How are we doing here?

chinmoyr updated this revision to Diff 24601.Jan 2 2018, 3:54 PM

1.Replaced PrivilegeExecution flag
2.Made variable m_flags const again

Restricted Application added a project: Frameworks. · View Herald TranscriptJan 2 2018, 3:54 PM
dfaure accepted this revision.Jan 10 2018, 11:24 PM
This revision is now accepted and ready to land.Jan 10 2018, 11:24 PM
This revision was automatically updated to reflect the committed changes.