[DropJob] Enable drag and drop in a read-only folder
ClosedPublic

Authored by chinmoyr on Aug 12 2017, 11:20 AM.

Details

Summary

This patch adds PrivilegeExecution and other relevant code to KIO::DropJob. With this DnD can be done in a read-only folder.

Diff Detail

Repository
R241 KIO
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
chinmoyr created this revision.Aug 12 2017, 11:20 AM
dfaure requested changes to this revision.Aug 13 2017, 10:03 PM

Looks good otherwise.

(Maybe extend the unittest for dropjob to test the polkit case too?)

src/widgets/dropjob.cpp
107

that line is clearly useless, given the line just before.

150

can be const again, given the above comment

This revision now requires changes to proceed.Aug 13 2017, 10:03 PM

How are we doing here?

chinmoyr updated this revision to Diff 24601.Tue, Jan 2, 3:54 PM

1.Replaced PrivilegeExecution flag
2.Made variable m_flags const again

Restricted Application added a project: Frameworks. · View Herald TranscriptTue, Jan 2, 3:54 PM
dfaure accepted this revision.Wed, Jan 10, 11:24 PM
This revision is now accepted and ready to land.Wed, Jan 10, 11:24 PM
This revision was automatically updated to reflect the committed changes.