Differential D7236

DesktopFileParser: add fallback lookup in ":/kservicetypes5/*"
ClosedPublic
Actions

Authored by dfaure on Aug 10 2017, 8:36 PM.

Details

Reviewers
mart
arichardson
davidedmundson
Commits
R244:2e5312416080: DesktopFileParser: add fallback lookup in ":/kservicetypes5/*"
Summary

This allows to bundle servicetype desktop files into libraries
to make it possible to run executables without the desktop file
installed.

Test Plan

kpackage unittests, after adding kpackage-generic.desktop
to a qrc file for kpackagetool.

Diff Detail

Repository
R244 KCoreAddons
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
dfaure created this revision.Aug 10 2017, 8:36 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptAug 10 2017, 8:36 PM
arichardson accepted this revision.Aug 25 2017, 7:30 PM

Looks good to me.
Test would be great but the patch is pretty trivial so not really needed.

This revision is now accepted and ready to land.Aug 25 2017, 7:30 PM
dfaure added a comment.Aug 25 2017, 7:32 PM

It will be tested at every "make test" in kio and kpackage ;-)

dfaure closed this revision.Aug 25 2017, 7:33 PM

Revision Contents
Changeset List

PathPackages
Msrc/lib/plugin/desktopfileparser.cpp (15 lines)

Diff 17982

View Options

src/lib/plugin/desktopfileparser.cpp

Loading...