Add some default shortcuts/input profiles for popular programs
ClosedPublic

Authored by woltherav on Dec 30 2015, 4:12 PM.

Details

Reviewers
abrahams
dkazakov
rempt
Group Reviewers
Krita
Summary

We've wanted to add PS and PT Sai shortcuts for a while now. This diff makes some base stuff for it.

Test Plan
  1. Not sure if all the shortcuts are correct. I tried my best of course, but there's a lot of these things.
  2. There's still odd bugs with the shortcuts system.
  3. Not sure what to do with shortcuts where there just isn't a match.
  4. Also confusion with seperation of input profile and shortcuts are still there. Would love it if this were streamlined.
  5. Minor bug found: If Krita can't find input for a new input profile action, it just crashes. Bad @dkazakov.
  6. We might want to add MyPaint and whatever shortcuts in the future too.
  7. PT Sai has both a shortcut for transparency(like our eraser blend mode) and shortcuts that pick a preset(for airbrush, smudge, eraser, inking brush, etc).

Diff Detail

Repository
R37 Krita
Lint
Lint Skipped
Unit
Unit Tests Skipped
woltherav updated this revision to Diff 1672.Dec 30 2015, 4:12 PM
woltherav retitled this revision from to Add some default shortcuts/input profiles for popular programs.
woltherav updated this object.
woltherav edited the test plan for this revision. (Show Details)
woltherav added reviewers: rempt, dkazakov, abrahams, Krita.
woltherav set the repository for this revision to R37 Krita.
woltherav added a project: Krita.
woltherav added a subscriber: dkazakov.
woltherav edited the test plan for this revision. (Show Details)Dec 30 2015, 4:35 PM
abrahams accepted this revision.Dec 31 2015, 8:16 PM
abrahams edited edge metadata.

This is awesome, thanks so much for putting it together.

Can you take off the v1 suffixes from the file names for now? If users want to customize the shortcuts those don't get overwritten, we would only need to have v1 and v2 if Krita itself provides multiple versions, and it's probably easier just to put the files in the repo and tweak them as needed later.

Then the remaining problems you listed can be moved to T1244 and I'll work on them from there.

This revision is now accepted and ready to land.Dec 31 2015, 8:16 PM

This is awesome, thanks so much for putting it together.

Can you take off the v1 suffixes from the file names for now? If users want to customize the shortcuts those don't get overwritten, we would only need to have v1 and v2 if Krita itself provides multiple versions, and it's probably easier just to put the files in the repo and tweak them as needed later.

Then the remaining problems you listed can be moved to T1244 and I'll work on them from there.

I am using versioning right now because I think that would make it easier when people come with adjustments. So that if a v2 shortcut sheet is out for PS, the user knows there's changes? Mostly because I am not certain about how good the shortcut sheets are right now, and how we intergrate non-ps and paint-tool sai shortcuts.

I'll add those things to the other task when my brain works again. Happy New Year!

woltherav closed this revision.Jan 1 2016, 10:58 AM

Commited in rKRITA82c3a474bcaf