Details
- Reviewers
scottpetrovic timotheegiet anikethgirish
Diff Detail
- Lint
Lint Skipped - Unit
Unit Tests Skipped
plugins/extensions/resourcemanager/dlg_bundle_manager.cpp | ||
---|---|---|
416 | After the first try for the search, the items don't get populated again. Need to fix that. |
plugins/extensions/resourcemanager/dlg_bundle_manager.cpp | ||
---|---|---|
401 | Need to check this out as well, I feel that the bundle after completely removing it, That bundle doesn't get deleted from the ResourceServer. |
plugins/extensions/resourcemanager/dlg_bundle_manager.cpp | ||
---|---|---|
386 | You need to add some null checking in here. I think this was the reason of my crashes. Something got out of sync with my files and the files couldn't be found. Adding something like this should help if (!file.isNull() && !file.isEmpty()) { d->model->importResourceFile( fi.absolutePath()+'/'+fi.fileName() , false ); } else { qDebug() << "file info does not exist while importing resource file"; } The idea is that these files should always be here. so the debug will help for a bit to figure out a deeper issue on why the file info is getting lost in the first place. | |
plugins/extensions/resourcemanager/entrydetailsdialog.cpp | ||
201 | Be careful when creating pointers in your code. This pointer is not being set free. This can cause a seg fault. see other areas of the code that use pointers to see how they de-allocate it |
plugins/extensions/resourcemanager/entrydetailsdialog.cpp | ||
---|---|---|
201 | Maybe it is ok though. I am not the best with pointers. Maybe someone else can chime in to set me straight if I am wrong. |
plugins/extensions/resourcemanager/dlg_bundle_manager.cpp | ||
---|---|---|
89 | Need to refactor this into a slotImportResource() or something. Because after importing a bundle the bundle manager isn't refreshing the list hence the items aren't shown in the listview. |