| cfeck | |
| broulik | |
| davidedmundson |
| Plasma |
This patch fixes the issue of processor numbers not being sorted in human-readable order.
It overloads the < operator on the SolDevice class to implement sorting by process number and sorting by storage volume names (as they should go, e.g.: sda, sda1, sda2...).
BUG: 380355
| Lint Skipped |
| Unit Tests Skipped |
Sorry for the long delay in responding - I will work on the suggestions this weekend.
Thanks for the feedback - diff has been updated
| Modules/devinfo/devicelisting.cpp | ||
|---|---|---|
| 49 ↗ | (On Diff #17758) | I've removed the disable as it's pointless |
| Modules/devinfo/soldevice.cpp | ||
| 165 ↗ | (On Diff #17758) | This is reversed as it's sorted in the opposite order (ascending) to the other entries (descending) |
| 169 ↗ | (On Diff #17758) | These are also sorted in ascending order, so that it goes from sda1, sda2, etc. |
| Modules/devinfo/soldevice.h | ||
| 108 ↗ | (On Diff #17758) | Habit - removed |
Working well, thanks and sorry it took so long.
Do you have commit access? You perhaps need to rebase the patch since in the meantime the code was modernized and your patch doesn't cleanly apply anymore. I can take care of this if you want.
Hi @broulik, I've rebased the diff based on the latest source revision (d3d3ee543a17a3859bf2204c15dc7c36804eed15).
Unfortunately I don't have commit access.