| davidedmundson |
| Plasma |
on multiscreen systems, the notification dialog gets resized to 0x0
right after componentcomplete by someone else (either kwin, notification
applet or Qt code) causing 382340, resizing a window to a null size is not correct anyways
and should never happen.
with this, all other resize events are correct and notifications are ok on multiscreen
systems
BUG:382340
system with primary monitor and panel in the external monitor
at the right of a panel, notifications are fine
| No Linters Available |
| No Unit Test Coverage |
| src/plasmaquick/dialog.cpp | ||
|---|---|---|
| 1045 | So it will never update its size? Shouldn't it be size == oldSize? | |
| src/plasmaquick/dialog.cpp | ||
|---|---|---|
| 1045 | ouch, sure, sorry :) | |
on multiscreen systems, the notification dialog gets resized to 0x0
by someone else (either kwin, notification applet or Qt code)
So which is it?
not sure how to proceed in debugging this, as all i have is a resize event handler being called, which a backtrace there is useless to figure out who is resizing it
finally figured out where this event is generated:
it's a spontaneous event generated in qguiapplication.cpp QGuiApplicationPrivate::processWindowScreenChangedEvent
around line 2209 QWindowSystemInterfacePrivate::GeometryChangeEvent gce(window, QHighDpi::fromNativePixels(window->handle()->geometry(), window), QRect());
this happens even before the first show event, right after the window has been created, the window is still 0x0, but the resize event gets delivered with 0x0 again and executed with all the bad side effects
this seems to happen for every window when there are multiple screens, so something we have probably to watch out for in the future
The commit still says "size != oldSize". Is this correct?
EDIT: Ah, there was a follow-up commit...