Differential D6950

Add support for Heat and Wait
ClosedPublic
Actions

Authored by rizzitello on Jul 27 2017, 12:57 PM.

Details

Reviewers
patrickelectric
tcanabrava
laysrodrigues
Commits
R232:517bf366e6ca: Add tests for Teacup::translate. Remove core->close(0) in clean up so the test…
R232:3d2838604568: Modify setBed and setExtruder Temperature functions to include andWait bool to…
R232:275de988307c: TeacupPlugin: Teacup lacks support for M190 and M109 that most others use for…
R232:83f5e249a480: Add a cb_andWait to allow users to enable heat and wait
R232:4a0597625475: Add support for Heat and Wait
R232:dd5382396858: Add support for M109 and M190 Add tests for M109/ M190
Summary

Use the M109 and M190 Gcodes to set heat and wait. (M116 to wait on teacup).

Test Plan

Needs testing on

  • Repetier
  • Marlin
  • Smoothie
  • Teacup
  • Sprinter
  • Aprinter

Diff Detail

Repository
R232 AtCore
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
rizzitello created this revision.Jul 27 2017, 12:57 PM
rizzitello updated this revision to Diff 17301.Jul 27 2017, 6:49 PM
  • Add support for M109 and M190 in gcodecommands
rizzitello edited the test plan for this revision. (Show Details)Jul 27 2017, 6:52 PM
rizzitello updated this revision to Diff 17343.Jul 28 2017, 10:18 PM
  • Rebase after merge of documents
rizzitello updated this revision to Diff 17455.Jul 31 2017, 7:41 PM
  • rebase to master
rizzitello updated this revision to Diff 17463.Jul 31 2017, 11:19 PM
  • rebase to master
rizzitello edited the test plan for this revision. (Show Details)Aug 23 2017, 3:31 AM
rizzitello updated this revision to Diff 18637.Aug 24 2017, 1:11 AM
  • TeacupPlugin: Teacup support for heat and wait
patrickelectric accepted this revision.Aug 24 2017, 10:59 PM
This revision is now accepted and ready to land.Aug 24 2017, 10:59 PM
rizzitello updated this revision to Diff 18838.Aug 27 2017, 11:51 AM
  • Add tests for M109 and M190
rizzitello edited the test plan for this revision. (Show Details)Aug 29 2017, 8:10 PM
rizzitello edited the summary of this revision. (Show Details)
rizzitello updated this revision to Diff 18980.Aug 30 2017, 8:03 PM
rizzitello edited the summary of this revision. (Show Details)
  • Rebase
  • Add tests for Teacup::translate.
  • Remove core->close(0) in clean up so the test finishes correctly.
rizzitello updated this revision to Diff 18982.Aug 30 2017, 8:07 PM
  • TeacupPlugin: Combine append statements
tcanabrava accepted this revision.Sep 3 2017, 9:31 AM

awesome man.

rizzitello updated this revision to Diff 19318.Sep 8 2017, 8:17 PM
  • Update base
rizzitello edited the test plan for this revision. (Show Details)Sep 8 2017, 8:21 PM
rizzitello updated this revision to Diff 19832.Sep 23 2017, 3:06 PM
  • Rebase to master
ngraham added a subscriber: ngraham.Oct 18 2017, 4:09 PM

Super cool. Can we land this?

rizzitello added a comment.Oct 18 2017, 9:04 PM

I would love to merge it, but I am still waiting to hear back from our smoothie tester before merge.

tcanabrava added a comment.Oct 19 2017, 7:35 AM

This simplifies the code quite much, so I'd rather you merge it and if there's a smoothie's bug, we fix it in another pull request.

Closed by commit R232:dd5382396858: Add support for M109 and M190 Add tests for M109/ M190 (authored by rizzitello). · Explain WhyOct 19 2017, 10:01 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/gcodecommands.cpp (13 lines)
Munittests/gcodetests.h (2 lines)
Munittests/gcodetests.cpp (12 lines)

Diff 20989

View Options

src/gcodecommands.cpp

Loading...
View Options

unittests/gcodetests.h

Loading...
View Options

unittests/gcodetests.cpp

Loading...