Details
- Reviewers
marten adridg ltoscano - Group Reviewers
FreeBSD - Commits
- R345:995e32b7c5bb: kmix assumes volume range 1:100 for oss mixer instead of 0:100.
Diff Detail
- Repository
- R345 KMix
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Given the amount of commits to the repository in the past years I'm not sure you'll be able to review this patch. Perhaps someone with a KDE Multimedia hat?
Added @marten who basically completed the Frameworks port.
My comment: please change 'See https://bugs.kde.org/344468' as the usual BUG: 344468
Also, if accepted, this patch should be committed with the name and email of the user that send it to bugzilla (git commit --author=...)
I've not touched this code area during the KF5 port, and neither am an expert in OSS, but am happy with the coding style and that it properly implements the fix as per the bug reports. Will give a +1 if nobody else will!
I was going to say "can't reproduce the original problem", but that is because this patch has been in production in the FreeBSD (which uses OSS) packages for years. So with Marten's OK in mind, I'll ACK it as well.
Just few notes:
- this is a bugfix, so it could go to Applications/17.08
- I still see 'See https://bugs.kde.org/344468', it should be BUG: 344468
- I can't see it from the log, but remember the author (you can ensure that everything is fine before pushing with arc land --hold)