[Folder View] Indicate cut items
AbandonedPublic

Authored by broulik on Jul 24 2017, 3:50 PM.

Details

Reviewers
hein
emmanuelp
dfaure
Group Reviewers
Plasma
VDG
Summary

This dims cut items similar to how Dolphin does it.

Test Plan

Cut a couple of files on my desktop, they got dimmed. If I copied something else they showed up again.
Also, cutting files from Dolphin updated FolderView right away.

I noticed that KUrlMimeData::urlsFromMimeData (or something else) seems quite slow, when I cut an entire folder in Dolphin (it is fine within FolderView from what I can tell), even if it's one we don't show in a FolderView, it can lead to a noticeable (as in a second or two) hickup in Plasma :/

Code is adapted from Dolphin.

Diff Detail

Repository
R119 Plasma Desktop
Lint
Lint Skipped
Unit
Unit Tests Skipped
broulik created this revision.Jul 24 2017, 3:50 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJul 24 2017, 3:50 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik edited the test plan for this revision. (Show Details)Jul 24 2017, 3:58 PM
broulik added inline comments.Jul 24 2017, 4:02 PM
containments/desktop/plugins/folder/foldermodel.cpp
1714

I think this check down here is wrong/not working properly

hein edited edge metadata.Aug 2 2017, 11:57 AM

I'm wondering if this should be done in KIO/KDirModel ... does Dolphin do this per-view too?

containments/desktop/plugins/folder/foldermodel.cpp
1714

Can you elaborate?

hein added a comment.Oct 24 2017, 7:11 AM

Kai, ping? IIRC we determined KDirModel does this already and this is misguided somehow?

broulik abandoned this revision.Apr 26 2018, 10:56 AM

Apparently it's not neeed, Wayland seems broken, probably doesn't get notified of QClipboard changes but this needs separate investigation