Remove unused khtml dependency
ClosedPublic

Authored by arojas on Jul 22 2017, 9:44 AM.

Details

Test Plan

Builds, works

Diff Detail

Repository
R340 Parley
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
arojas created this revision.Jul 22 2017, 9:44 AM
aacid added a subscriber: aacid.Jul 22 2017, 11:05 AM

Undecided, it is indeed unused but just because

./src/editor/editor.cpp:357: //BrowserWidget *htmlPart = new BrowserWidget(browserDock);

Is commented out, do you have time to read the git log to figure out if it is commented because of porting issues or because it is a feature that was never finished?

arojas updated this revision to Diff 17016.Jul 22 2017, 11:13 AM

Only comment it out, the code using it is still there

In D6827#127516, @aacid wrote:

Is commented out, do you have time to read the git log to figure out if it is commented because of porting issues or because it is a feature that was never finished?

Apparently the plan is to reenable it
https://github.com/KDE/parley/commit/dd663f5417994abca089ea6b2bb6daeeaa92011d

So only comment it out instead of removing it

aacid accepted this revision.Jul 22 2017, 2:46 PM
This revision is now accepted and ready to land.Jul 22 2017, 2:46 PM
This revision was automatically updated to reflect the committed changes.