Differential D6778

Port to KStandardAction::MoveToTrash
ClosedPublic
Actions

Authored by elvisangelaccio on Jul 19 2017, 8:23 AM.

Tags

None

Subscribers

davidedmundson, Konqueror

Details

Reviewers

Group Reviewers

Commits

R318:4b5ea05b6760: Port to KStandardAction::MoveToTrash

Summary

It was introduced in kconfig(widgets) 5.25. Using the standard action
results in less code and no need to hardcode the Del shortcut.

Test Plan

Change shortcut in System Settings -> Shortcuts -> Standard Shortcuts
Make sure the new shortcut is used by dolphin.

Diff Detail

Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

elvisangelaccio created this revision.Jul 19 2017, 8:23 AM

Restricted Application added a subscriber: Konqueror. · View Herald TranscriptJul 19 2017, 8:23 AM

elvisangelaccio added a dependent revision: D6779: Drop duplicate i18n strings.Jul 19 2017, 8:45 AM

davidedmundson added a subscriber: davidedmundson.Jul 19 2017, 9:07 AM

davidedmundson added inline comments.

src/dolphinpart.rc
2	if you change an rc file you need to update the version. Otherwise users with customised toolbars will have a broken entry.
src/dolphinui.rc
2	and here

elvisangelaccio added inline comments.Jul 19 2017, 9:08 AM

src/dolphinpart.rc
2	Right, totally forgot to bump the version...

Bump kpartgui version

elvisangelaccio marked 2 inline comments as done.Jul 19 2017, 9:12 AM

davidedmundson accepted this revision.Jul 19 2017, 9:17 AM

This revision is now accepted and ready to land.Jul 19 2017, 9:17 AM

Closed by commit R318:4b5ea05b6760: Port to KStandardAction::MoveToTrash (authored by elvisangelaccio). · Explain WhyJul 27 2017, 2:16 PM

This revision was automatically updated to reflect the committed changes.

elvisangelaccio mentioned this in D7520: Fix icon of KStandardAction::MoveToTrash.Aug 25 2017, 1:46 PM

Revision Contents
Changeset List

			Path	Packages
M			src/dolphincontextmenu.cpp (2 lines)
M			src/dolphinmainwindow.cpp (2 lines)
M			src/dolphinpart.cpp (4 lines)
M			src/dolphinpart.rc (8 lines)
M			src/dolphinremoveaction.h (2 lines)
M			src/dolphinremoveaction.cpp (2 lines)
M			src/dolphinui.rc (10 lines)
M			src/views/dolphinviewactionhandler.cpp (10 lines)

Diff 17294

src/dolphincontextmenu.cpp

Loading...

src/dolphinmainwindow.cpp

Loading...

src/dolphinpart.cpp

Loading...

src/dolphinpart.rc

Loading...

src/dolphinremoveaction.h

Loading...

src/dolphinremoveaction.cpp

Loading...

src/dolphinui.rc

Loading...

src/views/dolphinviewactionhandler.cpp

Loading...