It should be different from the DeleteFile icon, otherwise it's not
possible to distinguish them.
Details
Details
- Reviewers
ngraham - Group Reviewers
Frameworks - Commits
- R265:b8641527bb67: Fix icon of KStandardAction::MoveToTrash
Open context menu of Dolphin (master) and press Shift.
Diff Detail
Diff Detail
- Repository
- R265 KConfigWidgets
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
I do have two somewhat different looking icons in the context menu.
user-trash is for a place, not an action, so this might lead to a colorized icon showing up in the menu (when using larger icon sizes and/or high dpi)
Comment Actions
dolphin git master? Make sure you have D6778, which is what caused the regression
user-trash is for a place, not an action, so this might lead to a colorized icon showing up in the menu (when using larger icon sizes and/or high dpi)
Right. Is there some other icon we could use?
Comment Actions
I support this change, for the additional reason that it's appropriate for the "move to trash" icon to be black, because red icons are for destructive changes, and moving something to the trash isn't a destructive change (it's the prelude to one). The actually destructive change now gets the red icon.