Differential D6705

Actually filter the tab properties sent to the host
ClosedPublic
Actions

Authored by fvogt on Jul 14 2017, 6:09 PM.

Details

Reviewers
broulik
davidedmundson
Group Reviewers
Plasma
Commits
R856:6d10d359a1c2: Actually filter the tab properties sent to the host
Summary

Previously it sent all information about a tab that it had, including
a base64 encoded JPG screenshot, causing quite a lot of traffic.

Test Plan

dbus-monitor shows a lot less traffic, krunner still lists the tabs
like before.

Diff Detail

Repository
R856 Plasma Browser Integration
Branch
tabfix (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
fvogt created this revision.Jul 14 2017, 6:09 PM
Restricted Application added a project: Plasma. · View Herald TranscriptJul 14 2017, 6:09 PM
broulik accepted this revision.Jul 14 2017, 6:12 PM

Where did you see a JPEG-encoded screenshot? Could perhaps be the favicon.

This revision is now accepted and ready to land.Jul 14 2017, 6:12 PM
fvogt added a comment.Jul 14 2017, 6:15 PM
In D6705#125503, @broulik wrote:

Where did you see a JPEG-encoded screenshot? Could perhaps be the favicon.

In extData["thumbnail"], much larger than a favicon should ever be.
Didn't get sent by opera 40, vivaldi 1.10 added it.

Closed by commit R856:6d10d359a1c2: Actually filter the tab properties sent to the host (authored by fvogt). · Explain WhyJul 14 2017, 6:16 PM
This revision was automatically updated to reflect the committed changes.
broulik added a comment.Jul 14 2017, 6:19 PM

Ah, ok, I only looked at Chrome documentation. Might come in handy for Task Manager thumbnails at some point :)

Revision Contents
Changeset List

PathPackages
Mextension/extension.js (2 lines)

Diff 16719

View Options

extension/extension.js

Loading...