Actually filter the tab properties sent to the host
ClosedPublic
Actions

Authored by fvogt on Jul 14 2017, 6:09 PM.

Details

Reviewers

broulik
davidedmundson

Group Reviewers

Plasma

Commits

Summary

Previously it sent all information about a tab that it had, including
a base64 encoded JPG screenshot, causing quite a lot of traffic.

Test Plan

dbus-monitor shows a lot less traffic, krunner still lists the tabs
like before.

Repository

R856 Plasma Browser Integration

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Where did you see a JPEG-encoded screenshot? Could perhaps be the favicon.

This revision is now accepted and ready to land.Jul 14 2017, 6:12 PM

In D6705#125503, @broulik wrote:

Where did you see a JPEG-encoded screenshot? Could perhaps be the favicon.

In extData["thumbnail"], much larger than a favicon should ever be.
Didn't get sent by opera 40, vivaldi 1.10 added it.

This revision was automatically updated to reflect the committed changes.

Ah, ok, I only looked at Chrome documentation. Might come in handy for Task Manager thumbnails at some point :)

			Path	Packages
M			extension/extension.js (2 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	16719	3109feb		Jul 14 2017, 6:09 PM	★	★
Diff 2	16720	3109feb	R856:6d10d359a1c2045fa388fa92ed12a43d3b14b58c	Jul 14 2017, 6:15 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
db33196da541	f6b61b1df444	3109febc160c	Fabian Vogt	Actually filter the tab properties sent to the host (Show More…)	Jul 14 2017, 6:05 PM