Verify This doesn't look bad on other platforms.
Per https://www.kdevelop.org/tags/kdevelop-5 it seems that Windows and Linux all depend on transparent status bar.
Verify This doesn't look bad on other platforms.
Per https://www.kdevelop.org/tags/kdevelop-5 it seems that Windows and Linux all depend on transparent status bar.
No Linters Available |
No Unit Test Coverage |
I only have access to OSX (and now a Linux VM) to test on:
before | before w/progressbar | after | after w/progressbar | |
OSX | ||||
Linux | ||||
(Did not submit after screenshots for Linux, but did verify there was no effect)
Will submit another diff to address the odd-sized 'pop up' button on OSX
shell/statusbar.cpp | ||
---|---|---|
51 | Suppose I could remove the "this->" That said, is this the best way to do this? |
shell/statusbar.cpp | ||
---|---|---|
51 | Never saw problems with status bar translucency on either Linux or Windows. Probably better to ifdef for Q_OS_MAC, to make it clear it's a work-around for OS X only. Also link this phab URL inside a comment just before that line. If it fixes the issue for you on OS X => Go for it. |