Due to small size, button Requires 'Qt::WA_MacMiniSize' attribute.
In addition, 'm_pButton->setMaximumHeight( maximumHeight );' caused problems.
Details
Details
Test on varity of platforms, verify popup button is as expected
Diff Detail
Diff Detail
- Repository
- R33 KDevPlatform
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
| Before | After (with D656) | |
| OSX |  |  |
| shell/progresswidget/statusbarprogresswidget.cpp | ||
|---|---|---|
| 73–89 | This caused the button to be 'cut off' vertically. Given that setting the maximumHeight did nothing on OSX, and on Linux the button appeared about the same size, I thought this was not required. However, upon testing, without this, the button is much larger on Linux. Will need to work on this a bit more. | |
Comment Actions
@kfunk: unfortunately this diff doesn't work entirely as I expected.
I'm trying to avoid #ifdef OSX type solutions.
Comment Actions
- Make status 'popup' button more appopriate size on OSX
- Just special case OSX, no good workaround
Comment Actions
This is the final result. with the #ifdef it only applies to OSX:
The root issue seems to be that QPushButton (and QToolButton) both return rather 'large' minimumSizeHint on Linux, which prompted the setMaximumHeight call. Unfortunately, on OSX this causes the button to be rendered with the bottom edge clipped. Luckily, on OSX the minumSizeHint is much smaller and the standard layout works fine.