amccann (Andrew McCann)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Oct 9 2015, 1:41 AM (441 w, 6 d)
Availability
Available

Recent Activity

Aug 8 2017

amccann committed R32:ea0bb6400504: Make kdevduchain use QStandardPaths for Cache location (authored by amccann).
Make kdevduchain use QStandardPaths for Cache location
Aug 8 2017, 4:58 PM
amccann committed R32:693b2f91d789: OSX: Make StatusBar transparent to clear up visual oddity (authored by amccann).
OSX: Make StatusBar transparent to clear up visual oddity
Aug 8 2017, 4:58 PM
amccann committed R32:0891cdf941aa: Make status 'popup' button more appopriate size on OSX (authored by amccann).
Make status 'popup' button more appopriate size on OSX
Aug 8 2017, 4:58 PM
amccann committed R32:c4511d65c167: Be explicit about special menu item roles, required to prevent menu items from… (authored by amccann).
Be explicit about special menu item roles, required to prevent menu items from…
Aug 8 2017, 4:58 PM
amccann committed R32:b3ddc3da2539: fix crash on navigation crash, when clicking on '__1' container of clang's… (authored by amccann).
fix crash on navigation crash, when clicking on '__1' container of clang's…
Aug 8 2017, 4:58 PM
amccann committed R32:bf2299f6726d: Don't segfault when dbus is not running (authored by amccann).
Don't segfault when dbus is not running
Aug 8 2017, 4:58 PM
amccann committed R32:2b2c17bbb3fa: boost include dirs (authored by amccann).
boost include dirs
Aug 8 2017, 4:58 PM
amccann committed R32:ae3e0cd4168f: make plugins load installed data from resources if not found in filesystem (authored by amccann).
make plugins load installed data from resources if not found in filesystem
Aug 8 2017, 4:58 PM
amccann committed R32:e4ce073663b9: KDevelop 5 : Fix HiDPI issue with project tree view (authored by amccann).
KDevelop 5 : Fix HiDPI issue with project tree view
Aug 8 2017, 4:57 PM
amccann committed R32:960e07ee69ae: Address style issues, Comment fix better (authored by amccann).
Address style issues, Comment fix better
Aug 8 2017, 4:57 PM
amccann added a commit to T664: KDevelop 5 release: Fix High-DPI issues: R32:e4ce073663b9: KDevelop 5 : Fix HiDPI issue with project tree view.
Aug 8 2017, 4:57 PM · KDevelop
amccann committed R32:b81cded8a302: Fix HiDPI issue with project tree view (authored by amccann).
Fix HiDPI issue with project tree view
Aug 8 2017, 4:57 PM

Dec 16 2015

amccann added a comment to D380: Correctly remove stale next bucket links when items are removed.

@olivierjg, I assume from your last comment that you mean to make more changes.
When this is the case, you can select "Changes Planned" (Not sure on the exact language, only visible to owner), as the Action and make a comment. It's useful because then this diff drops out of everyone else's 'action required' list.

Dec 16 2015, 12:58 AM · KDevelop
amccann committed R33:ea0bb6400504: Make kdevduchain use QStandardPaths for Cache location (authored by amccann).
Make kdevduchain use QStandardPaths for Cache location
Dec 16 2015, 12:42 AM
amccann closed D659: Make kdevduchain use QStandardPaths for Cache location by committing R33:ea0bb6400504: Make kdevduchain use QStandardPaths for Cache location.
Dec 16 2015, 12:42 AM · KDevelop

Dec 15 2015

amccann added a reviewer for D659: Make kdevduchain use QStandardPaths for Cache location: KDevelop.
Dec 15 2015, 7:25 PM · KDevelop
amccann retitled D659: Make kdevduchain use QStandardPaths for Cache location from to Make kdevduchain use QStandardPaths for Cache location.
Dec 15 2015, 7:25 PM · KDevelop
amccann committed R33:0891cdf941aa: Make status 'popup' button more appopriate size on OSX (authored by amccann).
Make status 'popup' button more appopriate size on OSX
Dec 15 2015, 7:21 PM
amccann closed D657: Make status 'popup' button more appopriate size on OSX by committing R33:0891cdf941aa: Make status 'popup' button more appopriate size on OSX.
Dec 15 2015, 7:21 PM
amccann committed R33:693b2f91d789: OSX: Make StatusBar transparent to clear up visual oddity (authored by amccann).
OSX: Make StatusBar transparent to clear up visual oddity
Dec 15 2015, 7:16 PM
amccann closed D656: OSX: Make StatusBar transparent to clear up visual oddity by committing R33:693b2f91d789: OSX: Make StatusBar transparent to clear up visual oddity.
Dec 15 2015, 7:16 PM · KDevelop
amccann added a comment to D657: Make status 'popup' button more appopriate size on OSX.

This is the final result. with the #ifdef it only applies to OSX:

Dec 15 2015, 7:13 PM
amccann updated the diff for D657: Make status 'popup' button more appopriate size on OSX.
  • Make status 'popup' button more appopriate size on OSX
  • Just special case OSX, no good workaround
Dec 15 2015, 7:04 PM
amccann added a comment to D656: OSX: Make StatusBar transparent to clear up visual oddity.

Addressed concern raised by @kfunk

Dec 15 2015, 5:39 PM · KDevelop
amccann added a comment to D656: OSX: Make StatusBar transparent to clear up visual oddity.
Dec 15 2015, 5:39 PM · KDevelop
amccann updated the diff for D656: OSX: Make StatusBar transparent to clear up visual oddity.
  • Add ifdef & comment
Dec 15 2015, 5:38 PM · KDevelop
amccann planned changes to D657: Make status 'popup' button more appopriate size on OSX.

@kfunk: unfortunately this diff doesn't work entirely as I expected.

Dec 15 2015, 8:17 AM
amccann added a comment to D657: Make status 'popup' button more appopriate size on OSX.
BeforeAfter (with D656)
OSX
Dec 15 2015, 8:14 AM
amccann retitled D657: Make status 'popup' button more appopriate size on OSX from to Make status 'popup' button more appopriate size on OSX.
Dec 15 2015, 6:45 AM
amccann updated the diff for D656: OSX: Make StatusBar transparent to clear up visual oddity.
  • Make StatusBar transparent to clear up visual oddity on OSX
  • do not need 'this->'
Dec 15 2015, 6:08 AM · KDevelop
amccann added reviewers for D656: OSX: Make StatusBar transparent to clear up visual oddity: KDevelop, mwolff, kfunk.
Dec 15 2015, 2:37 AM · KDevelop
amccann added inline comments to D656: OSX: Make StatusBar transparent to clear up visual oddity.
Dec 15 2015, 2:36 AM · KDevelop
amccann added a comment to D656: OSX: Make StatusBar transparent to clear up visual oddity.

I only have access to OSX (and now a Linux VM) to test on:

Dec 15 2015, 2:35 AM · KDevelop
amccann retitled D656: OSX: Make StatusBar transparent to clear up visual oddity from to OSX: Make StatusBar transparent to clear up visual oddity.
Dec 15 2015, 2:26 AM · KDevelop

Dec 13 2015

amccann abandoned D626: Use 'cache' standard path.

Got things working without this change. Not necessary.

Dec 13 2015, 8:55 AM · KDevelop

Dec 4 2015

amccann committed R32:41ae241cc52b: OSX: Kdelibs4ConfigMigrator needs to happen after App object is created. (authored by amccann).
OSX: Kdelibs4ConfigMigrator needs to happen after App object is created.
Dec 4 2015, 5:54 PM
amccann closed D624: OSX: Kdelibs4ConfigMigrator needs to happen after App object is created. by committing R32:41ae241cc52b: OSX: Kdelibs4ConfigMigrator needs to happen after App object is created..
Dec 4 2015, 5:54 PM · KDevelop
amccann committed R33:c4511d65c167: Be explicit about special menu item roles, required to prevent menu items… (authored by amccann).
Be explicit about special menu item roles, required to prevent menu items…
Dec 4 2015, 5:53 PM
amccann closed D625: Be explicit about special menu item roles, required to prevent menu items from missing on OSX by committing R33:c4511d65c167: Be explicit about special menu item roles, required to prevent menu items….
Dec 4 2015, 5:53 PM · KDevelop
amccann added a member for KDevelop: amccann.
Dec 4 2015, 5:50 PM
amccann added a comment to D626: Use 'cache' standard path.

@kfunk, ah! Thought it was only stuff like DUChain data. Entirely rebuildable, and thus the cache location seeming OK.

Dec 4 2015, 5:48 PM · KDevelop
amccann updated D626: Use 'cache' standard path.
Dec 4 2015, 6:22 AM · KDevelop
amccann retitled D626: Use 'cache' standard path from to Use 'cache' standard path.
Dec 4 2015, 6:16 AM · KDevelop
amccann added a comment to D625: Be explicit about special menu item roles, required to prevent menu items from missing on OSX.

Not sure if the comment on each line was necessary.

Dec 4 2015, 5:09 AM · KDevelop
amccann added reviewers for D625: Be explicit about special menu item roles, required to prevent menu items from missing on OSX: KDevelop, kfunk, mwolff.
Dec 4 2015, 5:08 AM · KDevelop
amccann retitled D625: Be explicit about special menu item roles, required to prevent menu items from missing on OSX from to Be explicit about special menu item roles, required to prevent menu items from missing on OSX.
Dec 4 2015, 5:07 AM · KDevelop
amccann updated the test plan for D624: OSX: Kdelibs4ConfigMigrator needs to happen after App object is created..
Dec 4 2015, 4:54 AM · KDevelop
amccann retitled D624: OSX: Kdelibs4ConfigMigrator needs to happen after App object is created. from to OSX: Kdelibs4ConfigMigrator needs to happen after App object is created..
Dec 4 2015, 4:50 AM · KDevelop
amccann accepted D622: Open File: Use KEncodingFileDialog only under KDE.

Tested on OSX, commented on a minor issue inline.

Dec 4 2015, 2:24 AM · KDevelop

Dec 1 2015

amccann added a comment to T664: KDevelop 5 release: Fix High-DPI issues.

@kfunk, thank you for the screenshots, that may help. For reference, what are the two shots from? top is linux, bottom windows? (guessing) .. I don't have either running.

Dec 1 2015, 6:56 PM · KDevelop

Nov 23 2015

amccann committed R33:b3ddc3da2539: fix crash on navigation crash, when clicking on '__1' container of clang's… (authored by amccann).
fix crash on navigation crash, when clicking on '__1' container of clang's…
Nov 23 2015, 8:49 PM
amccann closed D564: fix crash on navigation crash, when clicking on '__1' container of clang's libc++ std::__1::string by committing R33:b3ddc3da2539: fix crash on navigation crash, when clicking on '__1' container of clang's….
Nov 23 2015, 8:49 PM · KDevelop
amccann added inline comments to D564: fix crash on navigation crash, when clicking on '__1' container of clang's libc++ std::__1::string.
Nov 23 2015, 8:48 PM · KDevelop

Nov 21 2015

amccann added a reviewer for D564: fix crash on navigation crash, when clicking on '__1' container of clang's libc++ std::__1::string: mwolff.
Nov 21 2015, 9:27 AM · KDevelop
amccann added inline comments to D564: fix crash on navigation crash, when clicking on '__1' container of clang's libc++ std::__1::string.
Nov 21 2015, 12:59 AM · KDevelop
amccann updated D564: fix crash on navigation crash, when clicking on '__1' container of clang's libc++ std::__1::string.
Nov 21 2015, 12:59 AM · KDevelop
amccann retitled D564: fix crash on navigation crash, when clicking on '__1' container of clang's libc++ std::__1::string from to fix crash on navigation crash, when clicking on '__1' container of clang's libc++ std::__1::string.
Nov 21 2015, 12:53 AM · KDevelop

Nov 12 2015

amccann committed R32:3c3d01fe78a4: Make kdevelop-app and kdev-plugins use Qt5 resources for splash, rc, knsrc (authored by amccann).
Make kdevelop-app and kdev-plugins use Qt5 resources for splash, rc, knsrc
Nov 12 2015, 12:50 PM
amccann closed D529: Make kdevelop-app and kdev-plugins use Qt5 resources for splash, rc, knsrc by committing R32:3c3d01fe78a4: Make kdevelop-app and kdev-plugins use Qt5 resources for splash, rc, knsrc.
Nov 12 2015, 12:50 PM · KDevelop
amccann added a comment to D529: Make kdevelop-app and kdev-plugins use Qt5 resources for splash, rc, knsrc.
Nov 12 2015, 12:49 PM · KDevelop
amccann added a comment to D529: Make kdevelop-app and kdev-plugins use Qt5 resources for splash, rc, knsrc.
Nov 12 2015, 12:48 PM · KDevelop
amccann committed R33:ae3e0cd4168f: make plugins load installed data from resources if not found in filesystem (authored by amccann).
make plugins load installed data from resources if not found in filesystem
Nov 12 2015, 12:45 PM
amccann closed D528: make plugins load installed data from resources if not found in filesystem by committing R33:ae3e0cd4168f: make plugins load installed data from resources if not found in filesystem.
Nov 12 2015, 12:45 PM · KDevelop
amccann updated the diff for D528: make plugins load installed data from resources if not found in filesystem.
  • more style concern
Nov 12 2015, 12:44 PM · KDevelop
amccann updated the diff for D529: Make kdevelop-app and kdev-plugins use Qt5 resources for splash, rc, knsrc.
  • address reviewed concerns
Nov 12 2015, 12:41 PM · KDevelop
amccann updated the diff for D528: make plugins load installed data from resources if not found in filesystem.
  • address style
Nov 12 2015, 12:40 PM · KDevelop
amccann updated the diff for D529: Make kdevelop-app and kdev-plugins use Qt5 resources for splash, rc, knsrc.
  • exclusivly load splash from QRC
Nov 12 2015, 11:26 AM · KDevelop
amccann added inline comments to D529: Make kdevelop-app and kdev-plugins use Qt5 resources for splash, rc, knsrc.
Nov 12 2015, 11:14 AM · KDevelop
amccann committed R33:bf2299f6726d: Don't segfault when dbus is not running (authored by amccann).
Don't segfault when dbus is not running
Nov 12 2015, 11:04 AM
amccann closed D527: Don't segfault when dbus is not running by committing R33:bf2299f6726d: Don't segfault when dbus is not running.
Nov 12 2015, 11:04 AM · KDevelop
amccann added a comment to D528: make plugins load installed data from resources if not found in filesystem.

@kfunk Yes..

Nov 12 2015, 10:53 AM · KDevelop
amccann added a comment to D528: make plugins load installed data from resources if not found in filesystem.

Related To D529 for kdevelop

Nov 12 2015, 3:19 AM · KDevelop
amccann added a comment to D529: Make kdevelop-app and kdev-plugins use Qt5 resources for splash, rc, knsrc.

Related To D528 for kdevplatform

Nov 12 2015, 3:17 AM · KDevelop
amccann retitled D529: Make kdevelop-app and kdev-plugins use Qt5 resources for splash, rc, knsrc from to Make kdevelop-app and kdev-plugins use Qt5 resources for splash, rc, knsrc.
Nov 12 2015, 3:15 AM · KDevelop
amccann added reviewers for D527: Don't segfault when dbus is not running: mwolff, kfunk.
Nov 12 2015, 3:12 AM · KDevelop
amccann retitled D528: make plugins load installed data from resources if not found in filesystem from to make plugins load installed data from resources if not found in filesystem.
Nov 12 2015, 3:04 AM · KDevelop
amccann retitled D527: Don't segfault when dbus is not running from to Don't segfault when dbus is not running.
Nov 12 2015, 2:21 AM · KDevelop

Nov 8 2015

amccann closed D508: boost include dirs by committing R33:2b2c17bbb3fa: boost include dirs.
Nov 8 2015, 1:12 AM · KDevelop
amccann committed R33:2b2c17bbb3fa: boost include dirs (authored by amccann).
boost include dirs
Nov 8 2015, 1:12 AM

Nov 7 2015

amccann added inline comments to D508: boost include dirs.
Nov 7 2015, 11:49 PM · KDevelop
amccann updated the diff for D508: boost include dirs.
  • Use arichardson's advice
Nov 7 2015, 11:48 PM · KDevelop
amccann retitled D508: boost include dirs from to boost include dirs.
Nov 7 2015, 9:24 AM · KDevelop

Oct 29 2015

amccann committed R32:c99d8a9db5c4: make qmljs kdevelop plugin compile on OSX (authored by amccann).
make qmljs kdevelop plugin compile on OSX
Oct 29 2015, 11:23 PM
amccann committed R32:f6af11bdee4f: Make OSX work like Windows with respect to KIO slave launching (authored by amccann).
Make OSX work like Windows with respect to KIO slave launching
Oct 29 2015, 10:07 PM
amccann committed R32:bfe757b31df6: Make OSX work like Windows with respect to KIO slave launching (authored by amccann).
Make OSX work like Windows with respect to KIO slave launching
Oct 29 2015, 10:07 PM
amccann closed D451: Make OSX work like Windows with respect to KIO slave launching by committing R32:f6af11bdee4f: Make OSX work like Windows with respect to KIO slave launching.
Oct 29 2015, 10:07 PM
amccann updated the diff for D451: Make OSX work like Windows with respect to KIO slave launching.

Make OSX work like Windows with respect to KIO slave launching

Oct 29 2015, 10:06 PM
amccann committed R32:cf2eb0948fb4: Fix problem with include paths with clang language parser (authored by amccann).
Fix problem with include paths with clang language parser
Oct 29 2015, 10:01 PM
amccann committed R32:a77ddc0f7c95: Do not add empty paths to include arguments for clang parser (authored by amccann).
Do not add empty paths to include arguments for clang parser
Oct 29 2015, 10:01 PM
amccann closed D450: Fix problem with include paths with clang language parser by committing R32:a77ddc0f7c95: Do not add empty paths to include arguments for clang parser.
Oct 29 2015, 10:01 PM · KDevelop
amccann updated the diff for D450: Fix problem with include paths with clang language parser.

Do not add empty paths to include arguments for clang parser

Oct 29 2015, 10:00 PM · KDevelop
amccann committed R32:b18b4a5a0ced: Enable HiDPI on OSX for KDevelop (authored by amccann).
Enable HiDPI on OSX for KDevelop
Oct 29 2015, 8:18 PM
amccann committed R32:a0b03afecddc: Enable HiDPI on OSX for KDevelop (authored by amccann).
Enable HiDPI on OSX for KDevelop
Oct 29 2015, 8:18 PM
amccann closed D449: Enable HiDPI on OSX for KDevelop by committing R32:a0b03afecddc: Enable HiDPI on OSX for KDevelop.
Oct 29 2015, 8:13 PM · KDevelop
amccann updated the diff for D449: Enable HiDPI on OSX for KDevelop.

rebased onto 5.0

Oct 29 2015, 8:10 PM · KDevelop
amccann added a comment to D434: KDevelop 5 : Fix HiDPI issue with project tree view.

Oops, I think at my place of work, we have arcanist configured to squash commits.

Oct 29 2015, 8:05 PM · KDevelop
amccann committed R33:e4ce073663b9: KDevelop 5 : Fix HiDPI issue with project tree view (authored by amccann).
KDevelop 5 : Fix HiDPI issue with project tree view
Oct 29 2015, 8:03 PM
amccann committed R33:b81cded8a302: Fix HiDPI issue with project tree view (authored by amccann).
Fix HiDPI issue with project tree view
Oct 29 2015, 8:02 PM
amccann committed R33:960e07ee69ae: Address style issues, Comment fix better (authored by amccann).
Address style issues, Comment fix better
Oct 29 2015, 8:02 PM
amccann added a commit to T664: KDevelop 5 release: Fix High-DPI issues: R33:e4ce073663b9: KDevelop 5 : Fix HiDPI issue with project tree view.
Oct 29 2015, 8:00 PM · KDevelop