Differential D656

OSX: Make StatusBar transparent to clear up visual oddity
ClosedPublic
Actions

Authored by amccann on Dec 15 2015, 2:26 AM.

Details

Reviewers
mwolff
kfunk
Group Reviewers
KDevelop
Commits
R33:693b2f91d789: OSX: Make StatusBar transparent to clear up visual oddity
R32:693b2f91d789: OSX: Make StatusBar transparent to clear up visual oddity
Test Plan

Verify This doesn't look bad on other platforms.

Per https://www.kdevelop.org/tags/kdevelop-5 it seems that Windows and Linux all depend on transparent status bar.

Diff Detail

Repository
R33 KDevPlatform
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
amccann updated this revision to Diff 1518.Dec 15 2015, 2:26 AM
amccann retitled this revision from to OSX: Make StatusBar transparent to clear up visual oddity.
amccann updated this object.
amccann edited the test plan for this revision. (Show Details)
Restricted Application added a subscriber: kdevelop-devel. · View Herald TranscriptDec 15 2015, 2:26 AM
amccann added a comment.Dec 15 2015, 2:35 AM

I only have access to OSX (and now a Linux VM) to test on:

beforebefore w/progressbarafterafter w/progressbar
OSX
Linux

(Did not submit after screenshots for Linux, but did verify there was no effect)

Will submit another diff to address the odd-sized 'pop up' button on OSX

amccann added inline comments.Dec 15 2015, 2:36 AM
shell/statusbar.cpp
51

Suppose I could remove the "this->"

That said, is this the best way to do this?

amccann added reviewers: KDevelop, mwolff, kfunk.Dec 15 2015, 2:37 AM
amccann added a project: KDevelop.
amccann updated this revision to Diff 1519.Dec 15 2015, 6:08 AM
  • Make StatusBar transparent to clear up visual oddity on OSX
  • do not need 'this->'
kfunk added inline comments.Dec 15 2015, 7:52 AM
shell/statusbar.cpp
51

Never saw problems with status bar translucency on either Linux or Windows.

Probably better to ifdef for Q_OS_MAC, to make it clear it's a work-around for OS X only. Also link this phab URL inside a comment just before that line.

If it fixes the issue for you on OS X => Go for it.

amccann updated this revision to Diff 1523.Dec 15 2015, 5:38 PM
  • Add ifdef & comment
amccann marked 2 inline comments as done.Dec 15 2015, 5:39 PM
amccann added a comment.Dec 15 2015, 5:39 PM

Addressed concern raised by @kfunk

Closed by commit R33:693b2f91d789: OSX: Make StatusBar transparent to clear up visual oddity (authored by amccann). · Explain WhyDec 15 2015, 7:16 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mshell/statusbar.cpp (8 lines)

Diff 1525

View Options

shell/statusbar.cpp

Loading...