check Buffer validity
ClosedPublic

Authored by mart on Jul 6 2017, 9:52 AM.

Details

Summary

if a plasma theme doesn't provide shadow graphics,
the buffer will be a nullptr as would be created
from an invalid image and would crash

BUG:381953

Test Plan

no crash anymore when using a theme that doesn't provide shadows

Diff Detail

Repository
R127 KWayland
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
mart created this revision.Jul 6 2017, 9:52 AM
Restricted Application added projects: Plasma on Wayland, Frameworks. · View Herald TranscriptJul 6 2017, 9:52 AM
Restricted Application added subscribers: Frameworks, plasma-devel. · View Herald Transcript

Same question as before, what happens when we go from a theme with shadows to a theme without?

mart added a comment.Jul 6 2017, 1:40 PM

Same question as before, what happens when we go from a theme with shadows to a theme without?

I tried to switch back and forth several times between breeze and keramiek(the theme linked in the bug which could reproduce the crash) and all seems to be fine

the shadows go from visible to absent and back and doesn't crash

davidedmundson accepted this revision.Jul 6 2017, 1:56 PM
This revision is now accepted and ready to land.Jul 6 2017, 1:56 PM
graesslin requested changes to this revision.Jul 6 2017, 2:51 PM
graesslin added a subscriber: graesslin.

please add a test case for the problem.

This revision now requires changes to proceed.Jul 6 2017, 2:51 PM
This revision was automatically updated to reflect the committed changes.

Erm why was this pushed although it was in state changes requested?