Differential D6394

Add KF6-TODO to make KComboBox::minimumSizeHint() public
ClosedPublic
Actions

Authored by kossebau on Jun 26 2017, 3:11 PM.

Tags

Subscribers

Details

Reviewers

Group Reviewers

Commits

R284:1910d3ac9b1e: Add KF6-TODO to make KComboBox::minimumSizeHint() public

Diff Detail

Repository

R284 KCompletion

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

kossebau created this revision.Jun 26 2017, 3:11 PM

Restricted Application added a project: Frameworks. · View Herald TranscriptJun 26 2017, 3:11 PM

apol added a subscriber: apol.Jun 26 2017, 3:14 PM

apol added inline comments.

src/kcombobox.h
527	Why KF6? changing visibility doesn't break ABI, AFAIK. We should just not reorder them.

kossebau added inline comments.Jun 26 2017, 3:36 PM

src/kcombobox.h
527	https://community.kde.org/Policies/Binary_Compatibility_Issues_With_C%2B%2B hints the access rights are mangled into the symbol signature with some compilers. At least MSVC is mentioned here: http://blog.qt.io/blog/2009/08/12/some-thoughts-on-binary-compatibility/ Happy to learn that things have changed meanwhile, this is my latest info on that matter, never heard of anything else :)

+1

That shouldn't have landed in "protected" area.

And no, MSVC has not changed :)

dfaure accepted this revision.Jun 26 2017, 8:49 PM

This revision is now accepted and ready to land.Jun 26 2017, 8:49 PM

Closed by commit R284:1910d3ac9b1e: Add KF6-TODO to make KComboBox::minimumSizeHint() public (authored by kossebau). · Explain WhyJun 27 2017, 8:26 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			src/kcombobox.h (2 lines)

Diff 15902

src/kcombobox.h

Loading...