Differential D630

Use tabletEvent->hiResGlobalPos without subtracting global widget position in scratchpad
ClosedPublic
Actions

Authored by abrahams on Dec 5 2015, 1:32 AM.

Details

Reviewers
tpaulssen
rempt
Maniphest Tasks
T683: Scratchpad doesn't work.
Summary

It's likely that this isn't the right fix, because "hiResGlobalPos" suggests it's supposed to be global, but in my tests it's in fact relative to the scratchpad widget.

Test Plan
  • Start Krita with an empty document
  • open the brush editor with a non-eraser brush
  • draw on the scratchpad with a stylus on a tablet
  • drawing should happen when patch is applied, but not when patch isn't applied

Diff Detail

Repository
R37 Krita
Lint
Lint Skipped
Unit
Unit Tests Skipped
tpaulssen updated this revision to Diff 1452.Dec 5 2015, 1:32 AM
tpaulssen retitled this revision from to Use tabletEvent->hiResGlobalPos without subtracting global widget position in scratchpad.
tpaulssen updated this object.
tpaulssen edited the test plan for this revision. (Show Details)
tpaulssen set the repository for this revision to R37 Krita.
tpaulssen added a project: Krita.
Restricted Application added a subscriber: woltherav. · View Herald TranscriptDec 5 2015, 1:32 AM
abrahams added a subscriber: abrahams.EditedDec 5 2015, 5:13 AM

Works for me!

I think just using tabletEvent->posF() produces the same effect though, so maybe we could go with that instead to avoid touching anything spooky.

rempt accepted this revision.Dec 5 2015, 8:58 AM
rempt added a reviewer: rempt.
rempt added a subscriber: rempt.

Thanks for the review, Michael!

This revision is now accepted and ready to land.Dec 5 2015, 8:58 AM
abrahams commandeered this revision.Dec 5 2015, 5:44 PM
abrahams added a reviewer: tpaulssen.

tpaulssen - I'll close out this revision for you since you pushed rKRITA132b010fa43f. You can make it happen automatically if you use arcanist, either by arc land or by pushing the commit message generated by arc diff.

abrahams closed this revision.Dec 5 2015, 5:44 PM

Closed by rKRITA132b010fa43f

Revision Contents
Changeset List

Diff 1452

View Options

krita/ui/widgets/kis_scratch_pad_event_filter.cpp

Loading...