Fix the label placement for Z axis
ClosedPublic

Authored by rizzitello on Jun 20 2017, 2:40 AM.

Details

Summary

The value of fontMetrics().xHeight() on windows is not the same as on linux . On windows fontMetrics().height() is used instead.

Test Plan

Try this on your machines and see if the z labels are inside the top and bottom boxes.

Diff Detail

Repository
R232 AtCore
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
rizzitello created this revision.Jun 20 2017, 2:40 AM

I did it this way because this complies the same as and reads alot better then

if(value < 0) { 
#ifndef Q_OS_WIN
    lb-> setX->method()
    lb-> setY->method()
#else 
    lb->setX->altMethod()
    lb->setY->altMethod()
#endif 
} else {
#ifndef Q_OS_WIN
    lb-> setX->method()
    lb-> setY->method()
#else 
    lb->setX->altMethod()
    lb->setY->altMethod()
#endif
}
rizzitello edited the summary of this revision. (Show Details)Jun 20 2017, 2:47 AM
rizzitello edited the test plan for this revision. (Show Details)
rizzitello added a subscriber: Atelier: AtCore.
rizzitello updated this revision to Diff 15875.Jun 26 2017, 1:41 PM
  • Rebase for newest changes
  • SVN_SILENT made messages (.desktop file) - always resolve ours
  • testclient: remove old Debian menu file
  • testclient: validation fixes for desktop file
  • Use fontMetrics().height() in place of fontMetrics().xHeight() on windows for Z axis label placement.
patrickelectric accepted this revision.Jun 26 2017, 2:15 PM
This revision is now accepted and ready to land.Jun 26 2017, 2:15 PM
tcanabrava accepted this revision.Jun 26 2017, 2:27 PM
rizzitello updated this revision to Diff 15877.Jun 26 2017, 2:39 PM
  • SVN_SILENT made messages (.desktop file) - always resolve ours
  • testclient: remove old Debian menu file
  • testclient: validation fixes for desktop file
  • Use fontMetrics().height() in place of fontMetrics().xHeight() on windows for Z axis label placement.
rizzitello updated this revision to Diff 15878.Jun 26 2017, 2:44 PM
  • Fix base to remove extra commits
This revision was automatically updated to reflect the committed changes.