Differential D6070

fix warnings from clazy with the default warning level
ClosedPublic
Actions

Authored by mgallien on Jun 2 2017, 7:22 PM.

Details

Reviewers

dfaure

Group Reviewers

Frameworks

Commits

R286:187055408f59: fix warnings from clazy with the default warning level

Summary

fix warnings from clazy with the default warning level

Test Plan

automatic tests still work as expected on Linux

Diff Detail

Repository

R286 KFileMetaData

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

mgallien created this revision.Jun 2 2017, 7:22 PM

Restricted Application added a project: Frameworks. · View Herald TranscriptJun 2 2017, 7:22 PM

I am not super sure about the struct -> class. Why?

autotests/taglibextractortest.cpp
118	Probably more elegant to use `constFirst` than `at(0)`. FWIW note that in this case we're patching so the warning is gone (which is not bad per se) but it's not like the software will be much better after this change. ^^'

replaced the at(0) by constFirst

In D6070#113705, @apol wrote:

I am not super sure about the struct -> class. Why?

I had missed the fact that the warnings where from clang and not clazy.
The compiler warns that the private class is first declared as a struct and later declared as a class ( -Wmismatched-tags is the warning flag from clang). I can remove those modifications if they are not desirable.

"first declared as a struct and later declared as a class" must indeed be fixed. It's only a warning for clang, but AFAIK it leads to a hard error with MSVC. So yes, this all looks good to me.

This revision is now accepted and ready to land.Jun 3 2017, 9:45 AM

Closed by commit R286:187055408f59: fix warnings from clazy with the default warning level (authored by mgallien). · Explain WhyJun 3 2017, 10:43 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			autotests/epubextractortest.cpp (2 lines)
M			autotests/exiv2extractortest.cpp (2 lines)
M			autotests/popplerextractortest.cpp (2 lines)
M			autotests/taglibextractortest.cpp (12 lines)
M			src/externalextractor.h (5 lines)
M			src/externalextractor.cpp (7 lines)
M			src/externalwriter.h (7 lines)
M			src/externalwriter.cpp (8 lines)
M			src/extractorcollection.cpp (8 lines)
M			src/writedata.h (2 lines)
M			src/writedata.cpp (4 lines)
M			src/writer.h (2 lines)
M			src/writer_p.h (3 lines)
M			src/writercollection.h (2 lines)
M			src/writercollection.cpp (5 lines)
M			src/writers/taglibwriter.cpp (1 line)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	15100	4829ff0		Jun 2 2017, 7:22 PM	★	★
Diff 2	15104	4829ff0	replaced the at(0) by constFirst	Jun 3 2017, 9:09 AM	★	★
Diff 3	15109	6b9a619	R286:187055408f59e219705b6e8594f665fc1bd83ee7	Jun 3 2017, 10:43 AM	★	★

Commit	Tree	Parents	Author	Summary	Date
cec944ce4985	a5a08bc0f612	4829ff0382fd	Matthieu Gallien	fix warnings from clazy with the default warning level (Show More…)	Jun 2 2017, 7:17 PM

fix warnings from clazy with the default warning levelClosedPublicActions

Details

Diff Detail

Revision ContentsChangeset List

Diff 15109

autotests/epubextractortest.cpp

autotests/exiv2extractortest.cpp

autotests/popplerextractortest.cpp

autotests/taglibextractortest.cpp

src/externalextractor.h

src/externalextractor.cpp

src/externalwriter.h

src/externalwriter.cpp

src/extractorcollection.cpp

src/writedata.h

src/writedata.cpp

src/writer.h

src/writer_p.h

src/writercollection.h

src/writercollection.cpp

src/writers/taglibwriter.cpp

fix warnings from clazy with the default warning level
ClosedPublic
Actions

Revision Contents
Changeset List