Workaround non-interactive file/places view on high dpi in multi monitor scenario
AbandonedPublic

Authored by broulik on May 31 2017, 9:57 AM.

Details

Summary

See linked bug report and comment in the code for more explanation.

CHANGELOG: Fixed issue where file area would become inaccessible in high-dpi multi-screen setup

BUG: 363548
FIXED-IN: 17.04.2

Test Plan

I know this is horrible and Qt must be fixed but this is such a major and weird bug and I'm lucky to at least found some way of working around it, I also couldn't figure out a simpler testcase for reporting a Qt bug. From what I can tell KMail's QtWebEngine view is also affected by this breaking in a similar fashion.

Ran QT_SCREEN_SCALE_FACTORS="2;2" dolphin, moved Dolphin to my second screen, opened a file, was still able to browse other folders and use the Places panel with this patch. Otherwise it would stop working and only work on the primary monitor.

Diff Detail

Repository
R318 Dolphin
Lint
Lint Skipped
Unit
Unit Tests Skipped
broulik created this revision.May 31 2017, 9:57 AM
Restricted Application added a project: Plasma. · View Herald TranscriptMay 31 2017, 9:57 AM
Restricted Application added subscribers: Konqueror, plasma-devel. · View Herald Transcript
dfaure edited edge metadata.EditedJun 1 2017, 6:49 AM

Excellent finding, it helped me reduce further the most annoying Qt bug I'm experiencing right now (in kmail)
--> https://bugreports.qt.io/browse/QTBUG-59017

dfaure requested changes to this revision.Jun 2 2017, 7:55 AM

Ths hack isn't horrible (window() makes sense too), however

  1. you might want to move the call to window() inside KRun itself so it applies to all apps
  2. please add a link to the QTBUG in a comment

I tested the qtbase fix and it works btw, so I expect Qt 5.9.1 to not have this issue anymore. A workaround for 5.9.0 is still interesting to have in, of course.

This revision now requires changes to proceed.Jun 2 2017, 7:55 AM