Set main window as parent of stand-alone popup menus
ClosedPublic

Authored by elvisangelaccio on May 31 2017, 9:48 AM.

Details

Summary

Stand-alone popup menus are <Menu> elements that are children of the
top-level <gui> element. Their initial parent is nullptr, but if we are
inside a QMainWindow we can use that as the parent. This ensures proper
placement of the menus on wayland (where parents are required in order to
have a transient parent window).

We also drop an old comment which claims popup menus should not have
parent.

Diff Detail

Repository
R263 KXmlGui
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Restricted Application added a project: Frameworks. · View Herald TranscriptMay 31 2017, 9:48 AM
Restricted Application added a subscriber: Frameworks. · View Herald Transcript
dfaure accepted this revision.Jun 1 2017, 6:42 AM
This revision is now accepted and ready to land.Jun 1 2017, 6:42 AM
This revision was automatically updated to reflect the committed changes.