Don't warn when attempting to remove a MainWindow container
AbandonedPublic

Authored by elvisangelaccio on May 29 2017, 5:34 PM.

Details

Reviewers
dfaure
Summary

MainWindow is a valid element that can contain other elements. We
shouldn't print a warning in this case.

Test Plan

latest ark git master (which has a <Menu> child of <MainWindow>) no longer prints:

Unhandled container to remove :  MainWindow

when the app is closed.

Diff Detail

Repository
R263 KXmlGui
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Restricted Application added a project: Frameworks. · View Herald TranscriptMay 29 2017, 5:34 PM
Restricted Application added a subscriber: Frameworks. · View Herald Transcript
dfaure edited edge metadata.May 29 2017, 5:43 PM

Containers are menus and toolbars, how can we possibly get here with a mainwindow as container? The fix doesn't looks horrible but I'm curious as to why this never happened before, what does ark do that nobody else ever did? Got a bt?

elvisangelaccio abandoned this revision.Jun 1 2017, 8:38 AM

Fixed with D6045.