| broulik |
| Plasma |
This code watches the device in the sysfs for changes, if device is
changed it reads the brightness again and updates it.
However that is,
a) Redundant: as if we update the brightness we already know what
brightness we set it to
b) Covers corner case: If something other then powerdevil updates the
brightness, this will update the internal brightness code accordingly
So, lets remove this extra overhead of going through udev/uevent and
make things bit more simpler
tested brightness control using keyboard, battery monitor
| No Linters Available |
| No Unit Test Coverage |
Right, yes.. but that corner case is very less likely to happen other then someone writing manually to sysfs file
Writing to sysfs brightness with some wonky bash script is a pretty common thing IMHO but any simplification of brightness code is a good thing. +1
Works fine for me in general, with 2 caveats:
In principle it works but when I unplug and plug back in AC, sometimes it changes brightness or at least moves the brightness slider around for some weird reason and then the brightness doesn't match the slider anymore.