| broulik |
| Plasma |
In normal backlight subsystem's drivers typical workflow is,
However in case of leds subsystem, kernel doesn't send uevent for
brightness change, hence uevent is never triggered and this doesn't
update cached value of brightness, resulting in DBus signal for
brightnessChanged never being emitted.
Tested on Nexus 5 which uses leds subsystem
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
| daemon/backends/upower/powerdevilupowerbackend.h | ||
|---|---|---|
| 122 | I suggest to use a different name. I read it as Controlled and just wanted to complain that the second L is uppercase. | |
| daemon/backends/upower/powerdevilupowerbackend.cpp | ||
|---|---|---|
| 55–58 | Put new var on a new line | |
| 196–200 | splitRef and QLatin1String Can't you do contains("/leds/") to reduce the likelihood of false positives? Or can it also be /sys/class/ledsfoo/ or sth like that? | |
| 457 | Make sure you don't emit if it didn't actually change (dunno what the code does internally so might already check for that) | |