Introduce DolphinMainWindowTest
ClosedPublic
Actions

Authored by elvisangelaccio on May 22 2017, 9:38 AM.

Details

Reviewers

emmanuelp
dfaure

Commits

R318:1faef1c92d16: Introduce DolphinMainWindowTest

Summary

For now it contains a test case for the crash in bug #379135

Test Plan

Builds, new test crashes (fix will be merged from Applications/17.04).

Repository

R318 Dolphin

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

This revision is now accepted and ready to land.May 23 2017, 7:12 AM

@dfaure thanks, could you also have a look at D5935 (which I need for this patch)?

This revision was automatically updated to reflect the committed changes.

		Path
M		src/dolphinmainwindow.cpp (1 line)
M		src/tests/CMakeLists.txt (5 lines)
A	M	src/tests/dolphinmainwindowtest.cpp (69 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	14755	2d65152		May 22 2017, 9:38 AM	★	★
Diff 2	14875	4216c7e	R318:1faef1c92d168e8f22d91d968c6fe29e70674699	May 27 2017, 8:28 AM	★	★

Commit	Tree	Parents	Author	Summary	Date
dd6735884d65	9f8fb79da4c3	2d65152fffc7	Elvis Angelaccio	Introduce DolphinMainWindowTest (Show More…)	May 22 2017, 9:37 AM

	Status	Author	Revision
	Closed	elvisangelaccio	D5936 Introduce DolphinMainWindowTest
	Closed	elvisangelaccio	D5935 Move non-exported code to a static library