Differential D5883

Revert "Increase smooth scrolling animation duration from 100 to 300 ms and set easing curve to InOutQuart"
ClosedPublic
Actions

Authored by elvisangelaccio on May 16 2017, 11:29 AM.

Details

Reviewers
emmanuelp
davidedmundson
Group Reviewers
VDG
Plasma
Commits
R318:883b908b4b26: Revert "Increase smooth scrolling animation duration from 100 to 300 ms and set…
Summary

This reverts commit 58c5eae1953bbdcf6d4150b21cb7ffdad07a5257.

Reasons against this change:

  1. Scroll is now too fast with devices such as touchpads or trackpoints.
  2. Scroll behavior is now inconsistent between Dolphin and other applications (e.g. the Plasma file dialog). Breeze's default animation duration is 100 ms.
  3. Many people complained and this feature is currently not configurable. We should introduce a QStyle::SH_Widget_Animation_Duration hint that would allow us to not hardcode durations in Dolphin (i.e. respect whatever duration the users set in their QStyle).

Diff Detail

Repository
R318 Dolphin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
Restricted Application added a project: Plasma. · View Herald TranscriptMay 16 2017, 11:29 AM
Restricted Application added subscribers: Dolphin, Konqueror, plasma-devel. · View Herald Transcript
elvisangelaccio added a comment.May 31 2017, 10:27 AM

Ping?
I'm going to push before the 17.04.2 tag, unless there are objections.

(for the record, https://codereview.qt-project.org/#/c/195712/ will make this feature configurable).

davidedmundson accepted this revision.May 31 2017, 10:31 AM
This revision is now accepted and ready to land.May 31 2017, 10:31 AM
Closed by commit R318:883b908b4b26: Revert "Increase smooth scrolling animation duration from 100 to 300 ms and set… (authored by elvisangelaccio). · Explain WhyMay 31 2017, 12:08 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 15018

View Options

src/kitemviews/private/kitemlistsmoothscroller.cpp

Loading...