Port away from deprecated QStyle::SH_Widget_Animate
ClosedPublic

Authored by elvisangelaccio on Jan 21 2018, 10:01 AM.

Details

Summary

Use the new QStyle::SH_Widget_Animation_Duration instead,
which allows us to not manually hardcode the duration.
We still use 1 if animations are disabled,
otherwise the scroll would not work at all.

See also D5883 for some background.

Test Plan

Played with different values in the Animation tab of the Breeze config dialog.

Diff Detail

Repository
R318 Dolphin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
elvisangelaccio requested review of this revision.Jan 21 2018, 10:01 AM
elvisangelaccio created this revision.
broulik accepted this revision.Jan 22 2018, 12:30 PM
broulik added a subscriber: broulik.

What's the value of SH_Widget_Animation_Duration? I think 100 ms in Breeze, so this should be fine.

This revision is now accepted and ready to land.Jan 22 2018, 12:30 PM

What's the value of SH_Widget_Animation_Duration?

It's the value from Breeze (or whatever is the current style)

This revision was automatically updated to reflect the committed changes.