Fixes D5747
Details
Details
Diff Detail
Diff Detail
- Repository
- R127 KWayland
- Branch
- master
- Lint
No Linters Available - Unit
No Unit Test Coverage
src/client/plasmawindowmodel.cpp | ||
---|---|---|
84 | In the original report I critized that we connect to a pid changed signal. That doesn't make any sense as a pid cannot change. I think this is the wrong solution to the problem. |
Comment Actions
It makes absolutely no sense to have a pidChanged signal and then say clients shouldn't be using it.
Either window has no reason to have a pidChanged signal or we should connect to it. It has to be one or the other.
Comment Actions
Right, the signal shouldn't exist. I overlooked that in the other review. Sorry. I pointed it out in two cases and missed the third. The signal should be removed IMHO.
Comment Actions
That would also be completely fine from my POV.
I should have read the original review request, I was just fixing the tests based on what was currently here.