Allow multiple categories with the same name
ClosedPublic

Authored by mart on Apr 26 2017, 4:55 PM.

Details

Summary

the category name was intended as a kind of unique id,
this isn't true anymore, so multiple categories can have
the same name (even if having a different display_name)
this makes content listing of category names with
multiple ids work

Test Plan

on store.kde.org the category 399 is going to have the
Plasma 5 Plasmoid name, tested with it and works (name
got back to the old one now)

Diff Detail

Repository
R304 KNewStuff
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
mart created this revision.Apr 26 2017, 4:55 PM
Restricted Application added projects: Plasma, Frameworks. · View Herald TranscriptApr 26 2017, 4:55 PM
Restricted Application added subscribers: Frameworks, plasma-devel. · View Herald Transcript
davidedmundson added inline comments.
src/attica/atticaprovider.cpp
129–134

mCategoryMap is pre-populated with null categories in the constructor.

This looks like this now won't ever update them.

mart updated this revision to Diff 14070.May 2 2017, 11:31 AM
  • remove empty placeholders
davidedmundson accepted this revision.May 3 2017, 11:13 AM
This revision is now accepted and ready to land.May 3 2017, 11:13 AM
This revision was automatically updated to reflect the committed changes.