Don't accept hover events in the DragArea
ClosedPublic

Authored by davidedmundson on Apr 25 2017, 12:10 AM.

Details

Summary

We don't actually process hoverEnter/move events, so there's no need to
have the overhead of having them sent to use.

We still get dragMove events regardless.

Setting it enabled broke FolderView nested in a grouping Plasmoid and
doesn't do anything useful.

Test Plan

Tested folderview in a grouping plasmoid
Also tested dragging an item from dolphin over an existing folderview.
Dragging over folders still worked as before

Diff Detail

Repository
R296 KDeclarative
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
Restricted Application added projects: Plasma, Frameworks. · View Herald TranscriptApr 25 2017, 12:10 AM
Restricted Application added subscribers: Frameworks, plasma-devel. · View Herald Transcript
aacid added a subscriber: aacid.Apr 25 2017, 3:15 PM

"Setting it enabled broke FolderView nested in a grouping Plasmoid" is this worth adding an auto test somewhere?

In D5573#104619, @aacid wrote:

"Setting it enabled broke FolderView nested in a grouping Plasmoid" is this worth adding an auto test somewhere?

Maybe, but it'd be testing that an item doesn't do what it had no reason to do in the first place.
There's an infinite number of random things this item shouldn't do, I don't see what we'd gain from testing this specific one.

It doesn't even look like it was introduced deliberately: 438b6485a481e4c11a3e719ff65adb0c631b96ad

aacid added a comment.Apr 25 2017, 3:41 PM

What about in the FolderView side?

hein accepted this revision.Apr 26 2017, 10:14 AM
hein added a subscriber: hein.

The FV side does rely on onDragMove firing, which is understand it still does regardless, so +1.

This revision is now accepted and ready to land.Apr 26 2017, 10:14 AM
This revision was automatically updated to reflect the committed changes.