Fix statusbar QT5 porting notes in Kubrick.
Details
Details
- Reviewers
- None
- Group Reviewers
KDE Games - Commits
- R419:a1afecdd80fb: Port statusbar to QStatusBar.
Status bar seems to work now.
Diff Detail
Diff Detail
- Repository
- R419 Kubrick
- Lint
Lint Skipped - Unit
Unit Tests Skipped
src/kubrick.cpp | ||
---|---|---|
81 ↗ | (On Diff #13756) | nit-picky: within this code base it seems to be common to have a space before the (). |
Comment Actions
Yeah, I started fixing these spaces after I done the patch but it seems I missed one. Thanks.
Comment Actions
Thanks, looks good to me.
Just curious. Is there (dis)advantages of using the QLabel as pointer vs. value here? I see is used as pointer in other games and used it like that as well.
But that's just curiosity, not a show-stopper for me.
Comment Actions
I don't know of any advantage/disadvantage... I can convert it to pointers if you want. Just an example I had was with objects and the code is one line shorter...