Differential D5571

Port statusbar to QStatusBar
ClosedPublic
Actions

Authored by stikonas on Apr 24 2017, 5:34 PM.

Details

Reviewers
None
Group Reviewers
KDE Games
Commits
R419:a1afecdd80fb: Port statusbar to QStatusBar.
Summary

Fix statusbar QT5 porting notes in Kubrick.

Test Plan

Status bar seems to work now.

Diff Detail

Repository
R419 Kubrick
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
stikonas created this revision.Apr 24 2017, 5:34 PM
schwarzer added a subscriber: schwarzer.Apr 24 2017, 5:39 PM
schwarzer added inline comments.
src/kubrick.cpp
81

nit-picky: within this code base it seems to be common to have a space before the ().

stikonas updated this revision to Diff 13757.Apr 24 2017, 5:42 PM

Yeah, I started fixing these spaces after I done the patch but it seems I missed one. Thanks.

schwarzer added a comment.Apr 24 2017, 5:54 PM

Thanks, looks good to me.
Just curious. Is there (dis)advantages of using the QLabel as pointer vs. value here? I see is used as pointer in other games and used it like that as well.

But that's just curiosity, not a show-stopper for me.

stikonas added a comment.Apr 24 2017, 6:24 PM

I don't know of any advantage/disadvantage... I can convert it to pointers if you want. Just an example I had was with objects and the code is one line shorter...

stikonas updated this revision to Diff 13763.Apr 24 2017, 7:13 PM
stikonas retitled this revision from Fix statusbar QT5 porting notes in Kubrick to Port statusbar to QStatusBar.
Closed by commit R419:a1afecdd80fb: Port statusbar to QStatusBar. (authored by stikonas). · Explain WhyApr 24 2017, 7:14 PM
This revision was automatically updated to reflect the committed changes.
ltoscano added a subscriber: ltoscano.Apr 24 2017, 7:16 PM

Accepted, but for future accounting please wait a bit for an official "Approval".

schwarzer added a comment.Apr 25 2017, 1:27 PM
In D5571#104467, @stikonas wrote:

I don't know of any advantage/disadvantage... I can convert it to pointers if you want. Just an example I had was with objects and the code is one line shorter...

Nah, as I said, it was just curiosity. :)

Revision Contents
Changeset List

PathPackages
Msrc/kubrick.h (3 lines)
Msrc/kubrick.cpp (30 lines)

Diff 13764

View Options

src/kubrick.h

Loading...
View Options

src/kubrick.cpp

Loading...