Differential D5458

craft: portage/extragear/konversation: Build 1.7 branch by default
ClosedPublic
Actions

Authored by alexeymin on Apr 15 2017, 8:40 AM.

Details

Reviewers
kfunk
vonreth
albertvaka
Group Reviewers
KDE Applications
Commits
R138:887375891ac0: craft: portage/extragear/konversation: Build 1.7 branch by default
Summary

portage/extragear/konversation: Build 1.7 branch by default, remove 1.6

Also allow building git master, but default to 1.7

Test Plan

1.7 branch actually builds under windows, unlike 1.6 with linking error about winsock libs

Diff Detail

Repository
R138 Craft
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
alexeymin created this revision.Apr 15 2017, 8:40 AM
kfunk accepted this revision.Apr 15 2017, 5:06 PM

Just remove 1.6 if it doesn't compile. Rest LGTM

This revision is now accepted and ready to land.Apr 15 2017, 5:06 PM
alexeymin updated this revision to Diff 13525.Apr 17 2017, 10:11 AM
alexeymin edited the summary of this revision. (Show Details)
alexeymin edited the test plan for this revision. (Show Details)

Removed 1.6 branch because it does not build

vonreth accepted this revision.Apr 17 2017, 10:30 AM
aacid added a subscriber: aacid.Apr 17 2017, 10:43 AM

Hannah, Kevin, can you please commit this?

Alexei doens't have commit access.

Alexey Min <alexey.min@gmail.com>

Closed by commit R138:887375891ac0: craft: portage/extragear/konversation: Build 1.7 branch by default (authored by alexeymin, committed by kfunk). · Explain WhyApr 17 2017, 3:41 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 13538

View Options

portage/extragear/konversation/konversation.py

Loading...