Differential D5413

makes KArchive be optional and do not build extractors needing it
ClosedPublic
Actions

Authored by mgallien on Apr 12 2017, 3:43 PM.

Details

Reviewers
kfunk
dfaure
Commits
R286:599e9b6489fe: makes KArchive be optional and do not build extractors needing it
Summary

Let Karchive be an optional build dependency of KFileMetaData

Test Plan

Still build with or without KArchive

Diff Detail

Repository
R286 KFileMetaData
Branch
karchive_optional
Lint
No Linters Available
Unit
No Unit Test Coverage
mgallien created this revision.Apr 12 2017, 3:43 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptApr 12 2017, 3:43 PM
Restricted Application added a subscriber: Frameworks. · View Herald Transcript
dfaure added a subscriber: dfaure.Apr 15 2017, 8:31 AM

Isn't this missing a "set_package_properties .. TYPE OPTIONAL" so that the user is told about the optional deps they're missing?
Not sure if that works for KF5 components.

heikobecker added a subscriber: heikobecker.Apr 15 2017, 1:33 PM
In D5413#102273, @dfaure wrote:

Isn't this missing a "set_package_properties .. TYPE OPTIONAL" so that the user is told about the optional deps they're missing?
Not sure if that works for KF5 components.

No, OPTIONAL is the default. But I'd say that using set_package_properties(...) including a meaningful "DESCRIPTION" and "PURPOSE" (e.g. like it's done for the other optional deps) is much nicer to packagers and others who try to build kfilemetadata.

kfunk requested changes to this revision.Apr 15 2017, 4:59 PM
kfunk added a subscriber: kfunk.

+1

This revision now requires changes to proceed.Apr 15 2017, 4:59 PM
mgallien updated this revision to Diff 13496.Apr 15 2017, 8:17 PM
mgallien edited edge metadata.

added a set_package_properties for KF5Archive

dfaure accepted this revision.Apr 16 2017, 7:47 AM
Closed by commit R286:599e9b6489fe: makes KArchive be optional and do not build extractors needing it (authored by mgallien). · Explain WhyApr 16 2017, 8:13 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
MCMakeLists.txt (8 lines)
Mautotests/CMakeLists.txt (20 lines)
Msrc/extractors/CMakeLists.txt (44 lines)

Diff 13496

View Options

CMakeLists.txt

Loading...
View Options

autotests/CMakeLists.txt

Loading...
View Options

src/extractors/CMakeLists.txt

Loading...