sometimes the downloaded file isn't correctly flushed to
disk, causing corrupted zip files, especially if they come
from github that does a redirect. Unconditionally closing it
fixes the problem
Details
Details
- Reviewers
bshah leinir - Group Reviewers
Plasma - Commits
- R304:925ec8a17ffb: always close the downloaded file after downloading
downloaded the unity8 gtk3 theme that comes from github and is fine,
other files coming directly from store.kde.org are fine as well
Diff Detail
Diff Detail
- Repository
- R304 KNewStuff
- Branch
- phab/closeFile
- Lint
No Linters Available - Unit
No Unit Test Coverage
Comment Actions
Yes, good catch. I am unsure of why that happened, but i quite agree, that certainly needs to happen whether or not a redirection has been involved.