always close the downloaded file after downloading

Authored by mart on Apr 11 2017, 6:03 PM.



sometimes the downloaded file isn't correctly flushed to
disk, causing corrupted zip files, especially if they come
from github that does a redirect. Unconditionally closing it
fixes the problem

Test Plan

downloaded the unity8 gtk3 theme that comes from github and is fine,
other files coming directly from are fine as well

Diff Detail

R304 KNewStuff
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.
mart created this revision.Apr 11 2017, 6:03 PM
Restricted Application added projects: Plasma, Frameworks. · View Herald TranscriptApr 11 2017, 6:03 PM
Restricted Application added subscribers: Frameworks, plasma-devel. · View Herald Transcript
leinir accepted this revision.Apr 12 2017, 8:13 AM

Yes, good catch. I am unsure of why that happened, but i quite agree, that certainly needs to happen whether or not a redirection has been involved.

This revision is now accepted and ready to land.Apr 12 2017, 8:13 AM
This revision was automatically updated to reflect the committed changes.