It turns out it's more complex than it looks, it's always better to have tests.
Details
Details
Diff Detail
Diff Detail
- Repository
- R240 Extra CMake Modules
- Branch
- master
- Lint
No Linters Available - Unit
No Unit Test Coverage
| tests/KDEFetchTranslations/CMakeLists.txt | ||
|---|---|---|
| 25 | AND NOT EXISTS "${CMAKE_CURRENT_SOURCE_DIR}/../../po" is the wrong path, it should be CMAKE_CURRENT_SOURCE_DIR/po. The effective source dir of the test is /tests/KDEFetchTranslations, so whether the ecm tree has a po has no impact on the target definition as it is effectively "scoped" to the /tests/KDEFetchTranslations tree. Negative side effect of the wrongness is that the test would not pass for tarballed builds with a /po dir as the asserted conditions suddenly is true ;) | |