Apply fix for bug 353715 also on QML side.
Details
Details
- Reviewers
mck182 - Group Reviewers
Plasma - Commits
- R242:a01e4fb69efe: Calendar: Use correct language for month and day names
I have English ui language + Czech time format. Months and days are now in English and not Czech.
Diff Detail
Diff Detail
- Repository
- R242 Plasma Framework (Library)
- Branch
- master
- Lint
No Linters Available - Unit
No Unit Test Coverage
Comment Actions
...provided the usage of uiLanguages[0] is safe like this.
| src/declarativeimports/calendar/qml/DaysCalendar.qml | ||
|---|---|---|
| 315 | Now I'm not entirely sure but can the uiLanguages[0] | |
| src/declarativeimports/calendar/qml/DaysCalendar.qml | ||
|---|---|---|
| 315 | It's used exactly the same on the C++ side (without the bounds check), so I assume it's safe as that code is now over 2 years old. | |
Comment Actions
I'm just curious. Why is the day name determined in QML (in the lines you edited, but was there before as well) and on the C++ side?
It smells like a redundancy.
As far as i can tell (only looked for a moment), the dayName on the C++ side isn't used "in" the C++ side. It's sole purpose is to be used by QML.
I'm fine with whatever you do though :)