Add syntax highlighting file for Doxyfile
ClosedPublic

Authored by kfunk on Apr 7 2017, 5:24 PM.

Diff Detail

Repository
R216 Syntax Highlighting
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
kfunk created this revision.Apr 7 2017, 5:24 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptApr 7 2017, 5:24 PM
Restricted Application added a subscriber: Frameworks. · View Herald Transcript
kfunk edited the summary of this revision. (Show Details)Apr 7 2017, 5:27 PM
kfunk added reviewers: vkrause, dhaumann, kwrite-devel.
vkrause accepted this revision.Apr 8 2017, 6:41 AM

Thank you, was missing this as well :) Just one nitpick: please make the license attribute more precise, e.g. "LGPLv2+". And if you happen to have a file around you can share, please add that to the unit test folder too.

This revision is now accepted and ready to land.Apr 8 2017, 6:41 AM
dhaumann edited edge metadata.Apr 8 2017, 7:42 AM

I would prevent MIT license for the highlighting - and also for the test.

kfunk added a comment.Apr 8 2017, 9:51 AM

What the... Created at almost the exact same time? :)

emaurer added a subscriber: emaurer.EditedApr 12 2017, 10:46 AM
In D5338#100575, @kfunk wrote:

What the... Created at almost the exact same time? :)

Hello guys, I was using my version for a long time and just Apr7 decided to commit,
and raised a pull request on Github.
and what I see - a couple hours earlier the same config was commited here :)

you see my version has a few minor enhancements, primary of these is a defining valid keywords.
I'm newbie here, need a some time to understand how to use the instruments.
after that, I'll suggest my additions to current version , if you do not mind

In D5338#100575, @kfunk wrote:

What the... Created at almost the exact same time? :)

Hello guys, I was using my version for a long time and just Apr7 decided to commit,
and raised a pull request on Github.
and what I see - a couple hours earlier the same config was commited here :)

you see my version has a few minor enhancements, primary of these is a defining valid keywords.
I'm newbie here, need a some time to understand how to use the instruments.
after that, I'll suggest my additions to current version , if you do not mind

Heya,

indeed, I saw that you had a set of valid keywords. If you're okay with it I'll just pull them in myself & then push this patch. We can work together on adding more stuff to it later on, no problem.

emaurer added a comment.EditedApr 12 2017, 11:58 AM

Heya,

indeed, I saw that you had a set of valid keywords. If you're okay with it I'll just pull them in myself & then push this patch. We can work together on adding more stuff to it later on, no problem.

sure, feel free to use from mine for a pushing

seems the key diferences are

  1. highlight a auto-generated comments between secions to see these during quick scrolling (comments like fullline #--------------------------------- (asked me by other man from this community)
  2. highlight varibles from build systems : with prefix @
  3. valid for doxy config keywords
turbov added a subscriber: turbov.Apr 12 2017, 2:51 PM

my 2 cents:

I've used the syntax made by Ernst quite a long time and pretty happy w/ it :)

dhaumann requested changes to this revision.Jun 17 2017, 3:06 PM

Any news on this? Also, do we have a unit test on this? Please decide on one version and make a review request again to get this done.

This revision now requires changes to proceed.Jun 17 2017, 3:06 PM

@emaurer We just agreed that your version is better and would like to use this. Are you also OK with using the MIT license? Currently, we are trying to unify the licensing to MIT for as many of our xml highlighting files as possible.

kfunk abandoned this revision.Jul 24 2017, 9:22 AM

Note: Abandoning this Diff in favor of the one from @emaurer

@emaurer We just agreed that your version is better and would like to use this. Are you also OK with using the MIT license? Currently, we are trying to unify the licensing to MIT for as many of our xml highlighting files as possible.

yes, confirmed, you can use the code with MIT license.

This revision was automatically updated to reflect the committed changes.