KPasswordDialog: don't hide visibility action in plaintext mode
ClosedPublic
Actions

Authored by elvisangelaccio on Apr 5 2017, 9:50 PM.

Details

Reviewers

fvogt
cfeck

Commits

R236:8a1c758516fd: KPasswordDialog: don't hide visibility action in plaintext mode

Summary

Otherwise the user cannot tell whether what's going to be typed will be
visible or not.

BUG: 378276
FIXED-IN: 5.34

Diff Detail

Repository

R236 KWidgetsAddons

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

elvisangelaccio created this revision.Apr 5 2017, 9:50 PM

Restricted Application added a project: Frameworks. · View Herald TranscriptApr 5 2017, 9:50 PM

Restricted Application added a subscriber: Frameworks. · View Herald Transcript

elvisangelaccio added a dependent revision: D5313: Add workaround for bug in QLineEdit's clear button.Apr 5 2017, 10:07 PM

Tested locally, works fine!

The behaviour is a bit unexpected, but IMO correct:

Enter a password
Make it visible
Delete it
Toggle visibility

-> VisibilityAction stays visible, although input empty and password hidden

This revision is now accepted and ready to land.Apr 6 2017, 7:02 AM

In D5312#100027, @fvogt wrote:

Tested locally, works fine!

The behaviour is a bit unexpected, but IMO correct:

Enter a password

Make it visible

Delete it

Toggle visibility -> VisibilityAction stays visible, although input empty and password hidden

Good catch. Yes it's a bit inconsistent, but indeed the alternative (toggle visibility -> icon just disappears) is probably worse.

@cfeck Ping?

elvisangelaccio mentioned this in D5530: KNewPasswordWidget: don't hide visibility action in plaintext mode.Apr 20 2017, 9:53 PM

Elvis, this was already accepted. If I had objections, I would have stopped you :)

Ok, I just wanted to be sure :)

Closed by commit R236:8a1c758516fd: KPasswordDialog: don't hide visibility action in plaintext mode (authored by elvisangelaccio). · Explain WhyApr 21 2017, 12:53 PM

This revision was automatically updated to reflect the committed changes.

elvisangelaccio mentioned this in R236:6976a54f2355: KNewPasswordWidget: don't hide visibility action in plaintext mode.

Revision Contents
Changeset List

		Path
M		autotests/CMakeLists.txt (1 line)
A	M	autotests/kpassworddialogautotest.h (34 lines)
A	M	autotests/kpassworddialogautotest.cpp (47 lines)
M		src/kpassworddialog.cpp (3 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	13123	34dfafa		Apr 5 2017, 9:50 PM	★	★
Diff 2	13667	d47b970	R236:8a1c758516fd606bce23dd92934d899f119ac49f	Apr 20 2017, 9:34 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
8d7ce83297d1	a6ca3afb191e	34dfafaf0d78	Elvis Angelaccio	KPasswordDialog: don't hide visibility action in plaintext mode (Show More…)	Apr 5 2017, 4:24 PM

	Status	Author	Revision
	Abandoned	elvisangelaccio	D5313 Add workaround for bug in QLineEdit's clear button
	Closed	elvisangelaccio	D5312 KPasswordDialog: don't hide visibility action in plaintext mode