Differential D5290

FindPyModGen: Don't hard-code share dir
Needs ReviewPublic
Actions

Authored by heikobecker on Apr 3 2017, 6:05 PM.

Details

Reviewers
None
Group Reviewers
Frameworks
Build System
Summary

...but use KDE_INSTALL_DATAROOTDIR instead.

Diff Detail

Repository
R240 Extra CMake Modules
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
heikobecker created this revision.Apr 3 2017, 6:05 PM
Restricted Application added projects: Frameworks, Build System. · View Herald TranscriptApr 3 2017, 6:05 PM
apol added a subscriber: apol.Apr 4 2017, 11:21 AM

That's not how ECM is intended to work, these find modules are supposed to be separate from the variables we use in KDE.

What problem are you trying to address?

heikobecker added a comment.Apr 4 2017, 5:55 PM
In D5290#99713, @apol wrote:

That's not how ECM is intended to work, these find modules are supposed to be separate from the variables we use in KDE.

What problem are you trying to address?

My distro uses a different approach to multiarch than e.g. Debian. We have use /usr/arch as prefix but arch independent files live below the prefix in /usr/share.

Would it be acceptable to use the equivalent variable from GNUInstallDirs?

apol added a comment.Apr 4 2017, 10:02 PM

How is this problem addressed elsewhere?

Revision Contents
Changeset List

Diff 13072

View Options

find-modules/FindPythonModuleGeneration.cmake

Loading...