Differential D5197

Make it possible to use the fetched translations
AbandonedPublic
Actions

Authored by apol on Mar 27 2017, 4:09 PM.

Details

Reviewers
None
Group Reviewers
Frameworks
Summary

Exemplifies how we'll have to change projects to adopt the changes.

Diff Detail

Repository
R325 KAlgebra
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
apol created this revision.Mar 27 2017, 4:09 PM
ltoscano added a subscriber: ltoscano.Mar 27 2017, 4:15 PM

I could not properly review the proposed patches which introduces the new functions (sorry), but do we need the if (EXISTS...) ? Before the changes, ki18n_install worked also when po/ did not exist.

apol updated this revision to Diff 12870.Mar 27 2017, 4:18 PM

Just try the directory, no need to make sure it's there

apol added a comment.Mar 27 2017, 4:18 PM
In D5197#97986, @ltoscano wrote:

I could not properly review the proposed patches which introduces the new functions (sorry), but do we need the if (EXISTS...) ? Before the changes, ki18n_install worked also when po/ did not exist.

Fixed, works.

apol updated this revision to Diff 13120.Apr 5 2017, 5:31 PM

FWIW this works, although it feels weird to include the source dir despite it not existing

apol abandoned this revision.Sep 28 2018, 4:41 PM
Restricted Application added a project: KDE Edu. · View Herald TranscriptSep 28 2018, 4:41 PM
Restricted Application added a subscriber: kde-edu. · View Herald Transcript

Revision Contents
Changeset List

PathPackages
MCMakeLists.txt (3 lines)

Diff 13120

View Options

CMakeLists.txt

Loading...