[DRM plugin] Correct Atomic Mode Setting
ClosedPublic
Actions

Authored by romangg on Mar 26 2017, 8:21 PM.

Details

Reviewers

fooishbar
graesslin

Group Reviewers

KWin

Commits

R108:d15cb52682ca: [DRM plugin] Correct Atomic Mode Setting

Summary

This patch makes the AMS execution path work with the new DrmCrtc and DrmBuffer structure and solves major issues about

VT switching
DPMS
Hot plugging
Logout
Memory leaks

It also aligns with changes made by @fooishbar to his WIP AMS branch for Weston, which I used as an example in the past.

In general with this patch AMS now should be ready for daily use.

Test Plan

Tested with Gl and QPainter. Currently to test AMS you need to set the environment variable KWIN_DRM_AMS or remove the condition in DrmBackend::openDrm().

Diff Detail

Repository

R108 KWin

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

romangg created this revision.Mar 26 2017, 8:21 PM

Restricted Application added a subscriber: kwin. · View Herald TranscriptMar 26 2017, 8:21 PM

romangg added a dependency: D5179: [DRM plugin] Reorganize DrmBuffer.Mar 26 2017, 8:24 PM

romangg mentioned this in D4539: [WIP][Drm Backend] Direct Buffer Scanout and Atomic Modesetting improvements.Mar 26 2017, 8:30 PM

Incorporate changes from stack (update to current master).

Last diff upload accidentally showed the total diff to master. Now again it only shows the diff to D5179.

graesslin accepted this revision.May 9 2017, 3:03 PM

This revision is now accepted and ready to land.May 9 2017, 3:03 PM

Closed by commit R108:d15cb52682ca: [DRM plugin] Correct Atomic Mode Setting (authored by romangg). · Explain WhyMay 9 2017, 10:20 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			plugins/platforms/drm/drm_backend.h (6 lines)
M			plugins/platforms/drm/drm_backend.cpp (43 lines)
M			plugins/platforms/drm/drm_object.h (59 lines)
M			plugins/platforms/drm/drm_object.cpp (36 lines)
M			plugins/platforms/drm/drm_object_connector.h (4 lines)
M			plugins/platforms/drm/drm_object_connector.cpp (13 lines)
M			plugins/platforms/drm/drm_object_crtc.h (5 lines)
M			plugins/platforms/drm/drm_object_crtc.cpp (15 lines)
M			plugins/platforms/drm/drm_object_plane.h (39 lines)
M			plugins/platforms/drm/drm_object_plane.cpp (99 lines)
M			plugins/platforms/drm/drm_output.h (23 lines)
M			plugins/platforms/drm/drm_output.cpp (405 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	12847			Mar 26 2017, 7:58 PM	★	★
Diff 2	14332			May 9 2017, 3:25 AM	★	★
Diff 3	14340			May 9 2017, 2:16 PM	★	★
Diff 4	14352	efedddd	R108:d15cb52682ca251b9d69f43e9b26d797e4dc3310	May 9 2017, 7:29 PM	★	★

Status	Author	Revision
Closed	romangg	D5191 [DRM plugin] Correct Atomic Mode Setting
Closed	romangg	D5179 [DRM plugin] Reorganize DrmBuffer
Closed	romangg	D5118 [DRM plugin] Remember static kernel objects, amplify use of DrmCrtc