Differential D5179

[DRM plugin] Reorganize DrmBuffer
ClosedPublic
Actions

Authored by romangg on Mar 26 2017, 1:54 AM.

Tags

Subscribers

Details

Reviewers

Group Reviewers

Commits

R108:efedddd905c3: [DRM plugin] Reorganize DrmBuffer

Summary

Split off GBM based buffers to a separate file, which gets only included, when GBM is available.

Note, that this also removes the gbmCallback, since already before this patch we did delete the buffers always without it.

Later we will use this file for via GBM directly imported Wayland buffers as well.

Test Plan

Tested with Gl and QPainter backends.

Diff Detail

Repository

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

romangg created this revision.Mar 26 2017, 1:54 AM

Restricted Application added a subscriber: kwin. · View Herald TranscriptMar 26 2017, 1:54 AM

romangg edited the summary of this revision. (Show Details)Mar 26 2017, 1:59 AM

romangg added a dependency: D5118: [DRM plugin] Remember static kernel objects, amplify use of DrmCrtc.

Merge changes from dependency.

Merge changes from dependency.

romangg added a dependent revision: D5191: [DRM plugin] Correct Atomic Mode Setting.Mar 26 2017, 8:24 PM

romangg mentioned this in D4539: [WIP][Drm Backend] Direct Buffer Scanout and Atomic Modesetting improvements.Mar 26 2017, 8:30 PM

graesslin accepted this revision.Apr 18 2017, 6:55 PM

This revision is now accepted and ready to land.Apr 18 2017, 6:55 PM

Incorporate changes from stack (update to current master).

Last diff upload accidentally showed the total diff to master. Now again it only shows the diff to D5118.

romangg mentioned this in D5191: [DRM plugin] Correct Atomic Mode Setting.May 9 2017, 2:19 PM

graesslin accepted this revision.May 9 2017, 3:02 PM

Closed by commit R108:efedddd905c3: [DRM plugin] Reorganize DrmBuffer (authored by romangg). · Explain WhyMay 9 2017, 10:20 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			plugins/platforms/drm/CMakeLists.txt (2 lines)
M			plugins/platforms/drm/drm_backend.h (19 lines)
M			plugins/platforms/drm/drm_backend.cpp (22 lines)
M			plugins/platforms/drm/drm_buffer.h (64 lines)
M			plugins/platforms/drm/drm_buffer.cpp (73 lines)
P			plugins/platforms/drm/drm_buffer_gbm.h (62 lines) Copied from plugins/platforms/drm/drm_object_crtc.h
A	M		plugins/platforms/drm/drm_buffer_gbm.cpp (69 lines)
P			plugins/platforms/drm/drm_object_crtc.h (3 lines) Copied to plugins/platforms/drm/drm_buffer_gbm.h
M			plugins/platforms/drm/drm_object_crtc.cpp (6 lines)
M			plugins/platforms/drm/drm_output.h (4 lines)
M			plugins/platforms/drm/drm_output.cpp (11 lines)
M			plugins/platforms/drm/scene_qpainter_drm_backend.h (4 lines)

Diff 14351

plugins/platforms/drm/CMakeLists.txt

Loading...

plugins/platforms/drm/drm_backend.h

Loading...

plugins/platforms/drm/drm_backend.cpp

Loading...

plugins/platforms/drm/drm_buffer.h

Loading...

plugins/platforms/drm/drm_buffer.cpp

Loading...

plugins/platforms/drm/drm_buffer_gbm.h

Loading...

plugins/platforms/drm/drm_buffer_gbm.cpp

Loading...

plugins/platforms/drm/drm_object_crtc.h

Loading...

plugins/platforms/drm/drm_object_crtc.cpp

Loading...

plugins/platforms/drm/drm_output.h

Loading...

plugins/platforms/drm/drm_output.cpp

Loading...

plugins/platforms/drm/scene_qpainter_drm_backend.h

Loading...