Differential D5090

User messages cleanup (and de-emphasize Konqueror)
ClosedPublic
Actions

Authored by ltoscano on Mar 18 2017, 12:02 AM.

Details

Reviewers

dfaure

Commits

R241:1693ee7a2501: User messages cleanup (and de-emphasize Konqueror)

Summary

more highlight on "applications that use a certain KIO", Konqueror is "just" an example of such applications;
specify KIO in addition to Konqueror in the user agent;
remove few possible references to KDE-as-the-destkop;
general cleanup of various user messages (configuration modules headlines, help messages);
fix the HTML tag inside quickHelp() messages (move <h1> outside <p>);
remove the reference to contents which has not be available for a long time into the kcms_smb (which should probably be moved under kio-extras with kio_smb).

Some of the kio_http references can be slightly less clear than
before, but KIO for sure can be used without Konqueror, so this
is a step forward.

BUG: 253389

Test Plan

Compiles, the updated strings are used.

Diff Detail

Repository

R241 KIO

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

ltoscano created this revision.Mar 18 2017, 12:02 AM

Restricted Application added a project: Frameworks. · View Herald TranscriptMar 18 2017, 12:02 AM

Restricted Application added a subscriber: Frameworks. · View Herald Transcript

lueck added a subscriber: lueck.Mar 18 2017, 9:42 AM

lueck added inline comments.

src/kcms/kio/smbrodlg.cpp
175–176	There are no fields named Browse server, Broadcast address, WINS address in the dialog, see https://bugs.kde.org/show_bug.cgi?id=253389 Last occurences of these strings are in https://websvn.kde.org/tags/KDE/3.3.0/kdebase/kcontrol/kio/ksmboptdlg.cpp?view=markup ksmboptdialog.cpp was replaced with smbrodlg.cpp without these strings with https://websvn.kde.org/trunk/kdebase/kcontrol/kio/smbrodlg.cpp?revision=76131&view=markup&pathrev=76131 Therefore everything about Browse server, Broadcast address, WINS address should be removed. Otherwise looks good to me. Thanks

aacid added a subscriber: aacid.Mar 18 2017, 10:34 AM

aacid added inline comments.

src/core/kprotocolmanager.cpp
844	This may be techinically correct, but it's going to break stuff that uses user agent detection (yes i know, that's broken but people use it still), so -1

ltoscano added inline comments.Mar 18 2017, 12:13 PM

src/core/kprotocolmanager.cpp
844	(like Gecko) kio_http/<ver> (previously Konqueror/<ver>) ? :)

ltoscano added inline comments.Mar 18 2017, 2:58 PM

src/kcms/kio/smbrodlg.cpp
175–176	I will fix it (basically removing most of the text), but I realize now that this KCM should not be here. The kio_smb is in kio-extras, this code should be moved there.

Few more cleanups and few suggested changes

ltoscano retitled this revision from More focus on KIO than Konqueror to More focus on KIO than Konqueror and msg cleanups.Mar 19 2017, 12:13 AM

ltoscano edited the summary of this revision. (Show Details)

ltoscano edited the test plan for this revision. (Show Details)

dfaure added inline comments.Mar 19 2017, 10:52 AM

src/core/kprotocolmanager.cpp
846	How about just KIO ? kio_http is unnecessarily specific IMHO. It's all of KIO/5.33 that ends up making up the http client.
src/kcms/kio/cache.cpp
109	Memory? that seems wrong (or at least misleading) to me. The kio_http cache is on disk, not in RAM.
src/kcms/kio/smbrodlg.cpp
175–176	I agree.

ltoscano added inline comments.Mar 19 2017, 2:45 PM

src/core/kprotocolmanager.cpp
846	Ack
src/kcms/kio/cache.cpp
109	Right, I simply fixed the Konqueror part but I did not read the whole sentence.

Apply the requested suggestions

ltoscano retitled this revision from More focus on KIO than Konqueror and msg cleanups to User messages cleanup (and de-emphasize Konqueror).Mar 19 2017, 2:48 PM

ltoscano edited the summary of this revision. (Show Details)

Looks good to me now. I'll let someone else do the final approval, since various of us commented.

dfaure accepted this revision.Mar 19 2017, 5:22 PM

This revision is now accepted and ready to land.Mar 19 2017, 5:22 PM

Closed by commit R241:1693ee7a2501: User messages cleanup (and de-emphasize Konqueror) (authored by ltoscano). · Explain WhyMar 19 2017, 8:00 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			src/core/kprotocolmanager.cpp (2 lines)
M			src/kcms/kio/cache.cpp (2 lines)
M			src/kcms/kio/kcookiesmain.cpp (10 lines)
M			src/kcms/kio/kcookiespolicies.cpp (4 lines)
M			src/kcms/kio/smb.desktop (2 lines)
M			src/kcms/kio/smbrodlg.cpp (19 lines)
M			src/kcms/kio/useragent.desktop (2 lines)
M			src/kcms/kio/useragentdlg.cpp (9 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	12575	cb3233a		Mar 18 2017, 12:02 AM	★	★
Diff 2	12607	cb3233a	Few more cleanups and few suggested changes	Mar 19 2017, 12:12 AM	★	★
Diff 3	12615	e449f82	Apply the requested suggestions	Mar 19 2017, 2:45 PM	★	★
Diff 4	12623	e449f82	R241:1693ee7a250128f7fbb3fd3b040d0e2273b11f3b	Mar 19 2017, 7:59 PM	★	★